Skip to content

Commit

Permalink
Merge pull request #129 from folio-org/wwelling-patch-1
Browse files Browse the repository at this point in the history
Correct comment regarding mapping parameters utility suppress warning
  • Loading branch information
wwtamu authored Dec 20, 2024
2 parents 904057a + 26a3520 commit bee0f32
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ public static JsonObject fetchRules(@NonNull OkapiRestTemplate restTemplate) {
* @throws ParametersRetrievalException if parameters cannot be retrieved
* @throws RestClientException if there's an error communicating
*/
@SuppressWarnings("java:S2259") // A "NullPointerException" could be thrown; "getParameters" is nullable here. This is a false negative.
@SuppressWarnings("java:S2259") // SonarQube false positive. getParameter throws exception if ResponseEntity hasBody is false.
public static MappingParameters getMappingParamaters(OkapiRestTemplate restTemplate) {
return new MappingParameters()
.withInitializedState(true)
Expand Down

0 comments on commit bee0f32

Please sign in to comment.