MODFQMMGR-675. Add Custom Fields support for Order and Order Line entities #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into MODFQMMGR-675 # Conflicts: # src/main/resources/entity-types/orders/composite_purchase_order_lines.json5
Comment on lines
+15
to
+23
| name: 'id', | ||
| sourceAlias: 'custom_fields', | ||
| dataType: { | ||
| dataType: 'rangedUUIDType', | ||
| }, | ||
| isIdColumn: true, | ||
| queryable: true, | ||
| visibleByDefault: false, | ||
| valueGetter: ':sourceAlias.id', |
There was a problem hiding this comment.
To make this more readable, you can remove all of the sourceAlias properties and change ":sourceAlias" in the valueGetters to ":custom_fields" like this:
Suggested change
| name: 'id', | |
| sourceAlias: 'custom_fields', | |
| dataType: { | |
| dataType: 'rangedUUIDType', | |
| }, | |
| isIdColumn: true, | |
| queryable: true, | |
| visibleByDefault: false, | |
| valueGetter: ':sourceAlias.id', | |
| name: 'id', | |
| dataType: { | |
| dataType: 'rangedUUIDType', | |
| }, | |
| isIdColumn: true, | |
| queryable: true, | |
| visibleByDefault: false, | |
| valueGetter: ':custom_fields.id', |
🙂
| @@ -0,0 +1,356 @@ | |||
| { | |||
There was a problem hiding this comment.
Is this entity type necessary?
There was a problem hiding this comment.
I will try with usinge simple custom field from users pacakge, because it is the same object, thanks
| @@ -59,6 +59,17 @@ | |||
| </createView> | |||
| </changeSet> | |||
|
|
|||
| <changeSet id="create_view_purchase_order_custom_fields" author="[email protected]"> | |||
There was a problem hiding this comment.
Can you add a runAlways="true" property to this changeSet? We'll be adding that to all of the source-view-creating changeSets very soon, so I just want to make sure this one doesn't fall through the cracks if it ends up getting merged immediately before or after that change 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
https://folio-org.atlassian.net/browse/MODFQMMGR-675