[MODSOURCE-854] Use deleteRecordBy id for soft delete of authority #668
+82
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanChernetskyi
requested review from
RuslanLavrov,
mukhiddin-yusuf,
psmagin,
Aliaksandr-Fedasiuk,
dmytrokrutii,
VRohach,
KaterynaSenchenko and
JavokhirAbdullayev
VRohach
reviewed
Feb 7, 2025
| LOG.info("handlePayload:: Handling 'delete' event for the record id = {}", payloadRecord.getId()); | ||
| recordService.updateRecordsState(payloadRecord.getMatchedId(), RecordState.DELETED, RecordType.MARC_AUTHORITY, payload.getTenant()) | ||
| recordService.deleteRecordById(payloadRecord.getMatchedId(), IdType.RECORD, okapiHeaders) | ||
| .recover(throwable -> throwable instanceof NotFoundException ? Future.succeededFuture() : Future.failedFuture(throwable)) |
There was a problem hiding this comment.
@RomanChernetskyi Let's log here smth. At the debug level - that record was not found (with specific Id). And warn level - with an error message and cause.
Aliaksandr-Fedasiuk
approved these changes
Feb 7, 2025
JavokhirAbdullayev
approved these changes
Feb 7, 2025
dmytrokrutii
approved these changes
Feb 7, 2025
psmagin
approved these changes
Feb 12, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Update soft delete logic for Marc Authority
Approach
Use deleteRecordBy id for soft delete of authority
Jira
https://folio-org.atlassian.net/browse/MODSOURCE-854