STCOM-1408: Add marginTop0 class to MessageBanner component

[mariia-aloshyna]

Introduce the marginTop0 class to the MessageBanner component to remove the default top margin.

Refs

https://folio-org.atlassian.net/browse/STCOM-1408

[github-actions]

Bigtest Unit Test Results

    1 files  ±0      1 suites  ±0   15s ⏱️ ±0s
1 536 tests +1  1 528 ✅ +1  8 💤 ±0  0 ❌ ±0 
1 538 runs  +1  1 530 ✅ +1  8 💤 ±0  0 ❌ ±0 

Results for commit c836e98. ± Comparison against base commit 2802f20.

♻️ This comment has been updated with latest results.

[zburke]

I'm lost here -- I see the prop and the style, but not where anything actually happens with that prop. How does this work?

[mariia-aloshyna]

I'm lost here -- I see the prop and the style, but not where anything actually happens with that prop. How does this work?

Oh hi @zburke I am going to introduce it in this PR you can see from the screenshot that there is an extra space between message banner and top border

[zburke]

Sorry my question wasn't clear, @mariia-aloshyna. What I meant was, I see this new prop on line 49, but it's never applied anywhere. The remaining props are collected into rest (line 50) which is then spread onto <Element> (line 110) but I don't see where marginTop0 is applied to a DOM element. What's the magic ✨ ?

[mariia-aloshyna]

Sorry my question wasn't clear, @mariia-aloshyna. What I meant was, I see this new prop on line 49, but it's never applied anywhere. The remaining props are collected into rest (line 50) which is then spread onto <Element> (line 110) but I don't see where marginTop0 is applied to a DOM element. What's the magic ✨ ?

No magic, I just missed a piece of code 🤦‍♀️. Updated the PR, thank you for catching it, now it works as expected.

[zburke]

No worries, PR review working exactly like it supposed to 🤝

How did that test ever pass though? 🤔

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud