-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(font): Atkinson Hyperlegible Next #100
feat(font): Atkinson Hyperlegible Next #100
Conversation
21afd4a
to
278a9fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, sorry for the delay in reviewing this! Can you please regenerate the package with the updated family name? Otherwise all the CSS, SCSS and docs would be using atkinson-hyperlegible-next
as the main name.
Also, we unfortunately don't support variable fonts from custom submissions. That's a system we automatically mirror from Google Fonts, so we need to remove that. 🙏
Change requested by @ayuhito fontsource#100 (comment) Co-authored-by: Ayu <[email protected]>
This is not supported in custom fonts as per @ayuhito fontsource#100 (review)
No worries on the delay, and a shame about the variable as that'd be very nice to use and save bandwidth. Both changes pushed as requested |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes. Just still need to fix this last thing!
Change requested by @ayuhito fontsource#100 (review)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks for the PR!
Atkinson Hyperlegible Next is the next generation of the Hyperlegible font from the Braille Institute with improved legability and variable font support.
This PR adds both the fixed variants and the variable font.