Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: store msg types inside message_type table and add messages_by_type function #105

Closed
wants to merge 9 commits into from

Conversation

MonikaCat
Copy link
Contributor

Description

Changes:

  • Stored messages types inside new message_type table
  • Added new messages_by_type function
  • Added v5 migrator to parse all msg types already stored in db

Checklist

  • Targeted PR against correct branch.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit tests.
  • Re-reviewed Files changed in the Github PR explorer.

@MonikaCat MonikaCat requested a review from RiccardoM January 26, 2024 11:33
@RiccardoM
Copy link
Contributor

RiccardoM commented Jan 26, 2024

I don't undestand: why is this necessary? Which use cases does it solve?

@MonikaCat
Copy link
Contributor Author

MonikaCat commented Jan 29, 2024

Hey @RiccardoM sure let me explain it a bit, so it's part of BDU-1150 issue, we want to allow users to filter the transactions by type on big dipper. I added new message_type table so we can quickly retrieve available msg types for each chain to display on big dipper. This will also help us to fix the message labels on big dipper as right now they are all hardcoded on the FE

@MonikaCat MonikaCat requested review from RiccardoM and removed request for RiccardoM February 1, 2024 07:41
@RiccardoM
Copy link
Contributor

@MonikaCat I don't believe this is something that should be done inside Juno. Instead, it should be done inside BDJuno since it is something that is custom to BigDipepr and not something that all parsers want to have. For example, Athena (DJuno) does not care about messages types. I would prefer we keep Juno as feature-agnostic as possible, moving all custom parsing logic into BDJuno or other parsers.

@MonikaCat
Copy link
Contributor Author

@RiccardoM ok I will move it to BDJuno, thanks 👍🏻

@MonikaCat MonikaCat closed this Feb 1, 2024
@MonikaCat MonikaCat deleted the dev/store-msg-types branch March 12, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants