build(salesforcedx-vscode): update node to v16 and switch from npm to yarn

.circleci/config.yml

@@ -24,8 +24,9 @@ parameters:
     type: string
     default: '3.13.1'
   node-version:
+    # 16.14 doesn't exist yet on https://hub.docker.com/r/circleci/node (Apr 2022)
     type: string
-    default: '14.16.0'
+    default: '16.13'
   # Constants
   cache-version:
     type: string
@@ -81,10 +82,12 @@ commands:
           name: 'Install dependent modules'
           shell: bash.exe
           command: |
-            npm config set scripts-prepend-node-path true
-            npm install
+            touch ~/.bashrc
+            curl -o- -L https://yarnpkg.com/install.sh | bash
+            source ~/.bashrc
             npm install -g sfdx-cli@<< pipeline.parameters.cli-version >>
             npm install -g junit-merge
+            yarn install --frozen-lockfile
       - run:
           name: 'Compile'
           shell: bash.exe
@@ -107,6 +110,7 @@ commands:
           name: 'Compile in << parameters.compile-mode >> mode'
           environment:
             - NODE_ENV: << parameters.compile-mode >>
+            - BASH_ENV: ~/.bashrc
           command: |
             npm run compile
 
@@ -136,9 +140,10 @@ commands:
   install:
     description: 'Installing dependencies'
     steps:
-      - run: npm ci
-      - run: npm --version
       - run: node --version
+      - run: npm --version
+      - run: yarn --version
+      - run: yarn install --frozen-lockfile
 
   merge-validation:
     description: 'Verify the release branch is not older than main'
@@ -207,7 +212,7 @@ commands:
     steps:
       - restore_cache:
           keys:
-            - << parameters.base-cache-path >>{{ checksum "package.json" }}
+            - << parameters.base-cache-path >>{{ checksum "yarn.lock" }}
 
   save_dependency_cache:
     parameters:
@@ -219,7 +224,7 @@ commands:
         default: 'node_modules'
     steps:
       - save_cache:
-          key: << parameters.base-cache-path >>{{ checksum "package.json" }}
+          key: << parameters.base-cache-path >>{{ checksum "yarn.lock" }}
           paths:
             - << parameters.path-to-save >>
 
@@ -294,6 +299,7 @@ jobs:
       - SFDX_AUTOUPDATE_DISABLE: true
       - SFDX_USE_GENERIC_UNIX_KEYCHAIN: true
       - SFDX_DOMAIN_RETRY: << pipeline.parameters.domain-retry >>
+      - BASH_ENV: ~/.bashrc
     steps:
       - build-artifacts
 
@@ -304,11 +310,12 @@ jobs:
       - SFDX_AUTOUPDATE_DISABLE: true
       - SFDX_DOMAIN_RETRY: << pipeline.parameters.domain-retry >>
       - NODE_VERSION: << pipeline.parameters.node-version >>
+      - BASH_ENV: ~/.bashrc
     steps:
       - build-win
       - run:
           name: 'Running unit tests'
-          shell: cmd.exe
+          shell: bash.exe
           command: npm run test:unit
       - run:
           name: 'Aggregate test results'
@@ -337,6 +344,7 @@ jobs:
       - SFDX_AUTOUPDATE_DISABLE: true
       - SFDX_DOMAIN_RETRY: << pipeline.parameters.domain-retry >>
       - NODE_VERSION: << pipeline.parameters.node-version >>
+      - BASH_ENV: ~/.bashrc
     steps:
       - build-win
       - run:
@@ -353,6 +361,7 @@ jobs:
       - SFDX_AUTOUPDATE_DISABLE: true
       - SFDX_DOMAIN_RETRY: << pipeline.parameters.domain-retry >>
       - NODE_VERSION: << pipeline.parameters.node-version >>
+      - BASH_ENV: ~/.bashrc
     steps:
       - build-win
       - run:
@@ -364,7 +373,7 @@ jobs:
             rm devhub.key
       - run:
           name: 'Running integration tests'
-          shell: cmd.exe
+          shell: bash.exe
           command: npm run test:integration-tests-without-system-tests
       - run:
           name: 'Assert all tests ran and aggregate results'
@@ -382,7 +391,7 @@ jobs:
           command: |
             [xml]$results = Get-Content junit-aggregate.xml
             $failure = $results.SelectSingleNode("//failure")
-            if ($failure -ne $null) { 
+            if ($failure -ne $null) {
               Write-Host "Forcing build failure due to test failure(s) :'("
               $host.SetShouldExit(1)
             }

.github/workflows/create-release-branch.yml

@@ -14,7 +14,7 @@ jobs:
     - name: Setup Node.js
       uses: actions/setup-node@v1
       with:
-        node-version: '14.16.x'
+        node-version: '16.14.x'
     - name: Checkout
       uses: actions/[email protected]
       with:

.npmrc

@@ -1,5 +1,19 @@
-#save exact versions of dependencies from the package.json
+# https://pnpm.io/npmrc
+
+# TODO: Can this be used instead of or in addition to nvm in CI and local dev
+# pnpm will automatically install the specified version of Node.js and use it for running pnpm run commands or the pnpm node command
+# use-node-version=16.13.0
+
+# Save dependencies to package.json with an exact version rather than using npm's default semver range operator
 save-exact=true
 
-#enforces usage of the minimum node version in our .nvmrc
-engine-strict=true
+# Refuse to install (or even consider installing) any package that claims to not be compatible with the current Node.js version.
+engine-strict=true
+
+# local packages from the workspace are preferred over packages from the registry, even if there is a newer version of the package in the registry
+prefer-workspace-packages=true
+
+auto-install-peers=true
+
+# pnpm will run any pre/post scripts automatically
+enable-pre-post-scripts=true

.nvmrc

@@ -1 +1 @@
-v14.16.0
+v16.14.0

contributing/developing.md

@@ -2,7 +2,7 @@
 
 ## Pre-requisites
 
-1.  We are requiring Node 14 at a minimum. If you need to work with multiple versions of Node, you
+1.  We are requiring Node 16 at a minimum. If you need to work with multiple versions of Node, you
     might consider using [nvm](https://github.com/creationix/nvm).
 1.  This repository uses [Lerna](https://lernajs.io/) to manage it as a
     _monorepo_. Please install Lerna globally using `npm install --global lerna`.
@@ -208,4 +208,4 @@ The npmrc allows for project-level [configuration](https://docs.npmjs.com/cli/v8
 
 ### .nvmrc
 
-Our nvmrc specifies the minimimum node version required to run the project.
+Our nvmrc specifies the minimum node version required to run the project.

contributing/publishing.md

@@ -213,11 +213,6 @@ from Atlassian on the flow. These steps are manual because you might encounter m
 
 # Tips
 
-1. After publishing, you will need to run `npm run bootstrap` again to continue
-   development. This is because the `npm run vscode:package` step does a `npm prune --production`. This is required due to the way Lerna does symlinking.
-   See [vscode-vsce#52](https://github.com/Microsoft/vscode-vsce/issues/52) for
-   more information.
-
 1. In order to make a previously unpublished extension publishable there are a
    few things that need to get updated:
    1. In packages/salesforcedx-vscode/package.json the extension needs to get added
@@ -228,7 +223,6 @@ from Atlassian on the flow. These steps are manual because you might encounter m
       For `repository` the url is `https://github.com/forcedotcom/salesforcedx-vscode`
    3. In the extension's package.json, under `scripts` the following attributes need
       to be defined:
-      `"vscode:prepublish": "npm prune --production"`
       `"vscode:package": "vsce package"`
       `"vscode:sha256": "node ../../scripts/generate-sha256.js >> ../../SHA256"`
       `"vscode:publish": "node ../../scripts/publish-vsix.js"`

contributing/tests.md

@@ -27,7 +27,7 @@ would write such tests using Mocha and Chai as you normally would for NPM module
 ### Unit Tests
 
 Place your strict unit tests in the `test/unit` directory of your package and create an npm
-script in your package.json like `"test:unit": "./node_modules/.bin/_mocha --recursive out/test/unit"`
+script in your package.json like `"test:unit": "yarn _mocha --recursive out/test/unit"`
 for running the tests. Check out the `"test:unit"` scripts in the package.json files for the
 salesforce-apex-debugger and salesforce-utils-vscode packages to see examples of how to configure
 code coverage reporting when running the tests.
@@ -41,7 +41,7 @@ There are tests that require integration with the Salesforce server. These tests
 require prior authentication to have occurred and a default devhub to be set.
 These show up in several packages. These tests are put under `test/integration`
 and are named in the standard `*.test.ts` pattern. The package.json should have an
-entry like `"test:integration": "./node_modules/.bin/_mocha --recursive out/test/integration"`.
+entry like `"test:integration": "yarn _mocha --recursive out/test/integration"`.
 Check out the `"test:integration"` scripts in the package.json files for the
 salesforce-apex-debugger and salesforce-utils-vscode packages to see how to additionally
 configure code coverage reporting.
@@ -158,14 +158,17 @@ There are tests that require integration with the Salesforce server. These tests
 require prior authentication to have occurred and a default devhub to be set.
 These show up in several packages. These tests are put under test/integration
 and named in the standard .test.ts pattern. The package.json should have an
-entry like `"test:integration": "cross-env VSCODE_NLS_CONFIG={} ./node_modules/nyc/bin/nyc.js ./node_modules/mocha/bin/_mocha --recursive out/test/integration"`.
+entry like
+> "test:integration": "cross-env VSCODE_NLS_CONFIG={} $(yarn bin nyc) $(yarn bin _mocha) --recursive out/test/integration"`
 
 These can be run in the same way from the CLI using `npm run test:integration`.
 Running `npm run test` will also run these.
 
 ## Unit Tests
 
-A module can also have an entry like `"test:unit": "node ./node_modules/nyc/bin/nyc.js ./node_modules/mocha/bin/_mocha --recursive out/test/unit"`.
+A module can also have an entry like
+> `"test:unit": "yarn nyc $(yarn bin _mocha) --recursive out/test/unit"`
+
 This is used for pure unit tests and for VS Code based tests discussed above.
 It is a good pattern to have an entry of `"test:unit"` in the package.json for
 modules that don't have separate integration tests.

lerna.json

@@ -1,4 +1,5 @@
 {
+  "version": "54.10.0",
   "packages": [
     "docs",
     "packages/*"