-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: update to node v16 with npm v6 for packaging #4092
Merged
Merged
Changes from 5 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
ec89666
ci: update to node v16 from node v14
f1880d5
build: update package lock to v2
1636411
build: update package engine and deps to node 16 with npm 6
be729ae
build: enable npm workspaces; thus updating lock file to account for …
2dd0eca
build: add npm script to install locally built vsix packages into ins…
d6140d1
docs: add info about new pkgs install script
c757794
build: fix mismatch peer dep versions in soql pkg; remove legacy peer…
a85953b
refactor: rename vscode:install to vsix:install
c88c38f
build: switch to lock file v3 for reduced file size and hopefully fas…
c37cb5d
refactor: npm run scripts to reuse targets
347e6f0
refactor: reinstall script to use git checkout to reset package lock …
5eb7b17
docs: add info about npm v6 vs npm v8
03d6914
Merge branch 'develop' into mohanraj-r/node16_npm8_update_take3
mohanraj-r 65eb8c5
docs: add info about legacy circle image and node version
172eaad
Merge remote-tracking branch 'origin/mohanraj-r/node16_npm8_update_ta…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,14 +7,14 @@ on: | |
jobs: | ||
create_branch: | ||
name: 'Create Branch' | ||
|
||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- name: Setup Node.js | ||
uses: actions/setup-node@v1 | ||
with: | ||
node-version: '14.16.x' | ||
node-version: '16.13.x' | ||
- name: Checkout | ||
uses: actions/[email protected] | ||
with: | ||
|
@@ -43,4 +43,3 @@ jobs: | |
# -H 'Authorization: Bearer ${{ secrets.SLACK_BOT_TOKEN }}' \ | ||
# -X POST -d "${{ github.event.client_payload.on_success }}" \ | ||
# https://slack.com/api/chat.update | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,13 @@ | ||
#save exact versions of dependencies from the package.json | ||
# https://docs.npmjs.com/cli/v8/using-npm/config | ||
|
||
# Save dependencies to package.json with an exact version rather than using npm's default semver range operator | ||
save-exact=true | ||
|
||
#enforces usage of the minimum node version in our .nvmrc | ||
engine-strict=true | ||
# Refuse to install (or even consider installing) any package that claims to not be compatible with the current Node.js version. | ||
engine-strict=true | ||
|
||
# If a package cannot be installed because of overly strict peerDependencies that collide, it provides a way to move forward resolving the situation. | ||
# TODO (debug): | ||
# npm ERR! While resolving: [email protected] | ||
# npm ERR! Found: @typescript-eslint/[email protected] | ||
legacy-peer-deps=true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
v14.16.0 | ||
v16.13.0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it suggest a version that works or what?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modified the peer/dev deps to match the versions and removed the legacy peer deps flag