Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a key binding to close windows #430

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

soitchu
Copy link

@soitchu soitchu commented Dec 18, 2024

Pressing Alt+F4 isn't always the most ergonomic option, so adding a key bind specifically for closing windows makes sense.

@PolGZ
Copy link

PolGZ commented Jan 27, 2025

I don't know anything about programming, so excuse me if what I say is dumb:

But can't one already achieve this by:

  • Just going into the default settings menu in gnome? (Keyboard > View and customize shortcuts > Windows > Close window). Or
  • Editing /org/gnome/desktop/wm/keybindings/close on dconf and setting the desired combination? (I have ['<Super>q'])

Maybe the PR edits the same thing, but since I don't see any reference to any sort of gsettings set org.gnome.desktop.wm.keybindings on the PR... I thought it might be useful to point it out. Since changing keybindings from Forge when gsettings is set to something else hasn't work for me.

Again, sorry if I'm just mistaken.

@soitchu
Copy link
Author

soitchu commented Jan 29, 2025

I don't know anything about programming, so excuse me if what I say is dumb:

But can't one already achieve this by:

* Just going into the default settings menu in gnome? (Keyboard > View and customize shortcuts > Windows > Close window). Or

* Editing `/org/gnome/desktop/wm/keybindings/close` on `dconf` and setting the desired combination? (I have `['<Super>q']`)

That's a totally valid way of doing that! I just thought having it in the extension itself would make the UX much better.

Since changing keybindings from Forge when gsettings is set to something else hasn't work for me.

Because of keybind conflicts? Or because it's trying to do the same thing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants