Merge branch 'develop' into simplify-spec-usage

* develop:
  remove remnants of phpunit
  use builtin memory assertion
  use builtin method to disable memory limit
  update changelog
  fix constructor
  use named constructors

.gitignore

@@ -1,6 +1,4 @@
 /composer.lock
 /vendor
-/.phpunit.result.cache
-/.phpunit.cache
 /.cache
 /tmp

CHANGELOG.md

@@ -8,12 +8,21 @@
 - `Formal\AccessLayer\Query\MultipleInsert`
 - `Formal\AccessLayer\Table\Column\Type::uuid()`
 - `Formal\AccessLayer\Table\Column\Type::bool()`
+- `Formal\AccessLayer\Connection\Lazy::of()`
+- `Formal\AccessLayer\Row::new()`
+- `Formal\AccessLayer\Row\Value::of()`
 
 ### Changed
 
 - Requires `innmind/specification:~4.1`
 - `Formal\AccessLayer\Query::sql()` now has a `Driver` argument
 - `Formal\AccessLayer\Query\Insert::into()` only accepts 1 `Row`, for multiple rows use `MultipleInsert` instead
+- `Formal\AccessLayer\Connection\Lazy` constructor is now private, use `::of()` instead
+- `Formal\AccessLayer\Row` constructor is now private, use `::new()` instead
+- `Formal\AccessLayer\Row\Value` constructor is now private, use `::of()` instead
+- `Formal\AccessLayer\Table\Column` constructor is now private, use `::of()` instead
+- `Formal\AccessLayer\Table\Column\Name` constructor is now private, use `::of()` instead
+- `Formal\AccessLayer\Table\Name` constructor is now private, use `::of()` instead
 
 ### Removed
 

README.md

@@ -29,7 +29,7 @@ use Formal\AccessLayer\{
 use Innmind\Url\Url;
 use Innmind\Immutable\Sequence;
 
-$connection = new Lazy(static fn() => PDO::of(Url::of('mysql://user:[email protected]:3306/database_name')));
+$connection = Lazy::of(static fn() => PDO::of(Url::of('mysql://user:[email protected]:3306/database_name')));
 
 $rows = $connection(SQL::of('SELECT * FROM `some_table`'));
 $rows; // instanceof Sequence<Row>

blackbox.php

@@ -3,15 +3,14 @@
 
 require 'vendor/autoload.php';
 
-\ini_set('memory_limit', '-1');
-
 use Innmind\BlackBox\{
     Application,
     Runner\Load,
     Runner\CodeCoverage,
 };
 
 Application::new($argv)
+    ->disableMemoryLimit()
     ->codeCoverage(
         CodeCoverage::of(
             __DIR__.'/src/',

documentation/connections/lazy.md

@@ -11,7 +11,7 @@ use Formal\AccessLayer\{
 };
 use Innmind\Url\Url;
 
-$connection = new Lazy(
+$connection = Lazy::of(
     static fn() => PDO::of(
         Url::of('mysql://user:[email protected]:3306/database_name'),
     ),

documentation/queries/create_table.md

@@ -8,13 +8,13 @@ use Formal\AccessLayer\{
 };
 
 $create = CreateTable::named(
-    new Name('users'),
-    new Column(
-        new Column\Name('username'),
+    Name::of('users'),
+    Column::of(
+        Column\Name::of('username'),
         Column\Type::varchar(),
     ),
-    new Column(
-        new Column\Name('name'),
+    Column::of(
+        Column\Name::of('name'),
         Column\Type::varchar(),
     ),
 );
@@ -31,13 +31,13 @@ use Formal\AccessLayer\{
 };
 
 $create = CreateTable::ifNotExists(
-    new Name('users'),
-    new Column(
-        new Column\Name('username'),
+    Name::of('users'),
+    Column::of(
+        Column\Name::of('username'),
         Column\Type::varchar(),
     ),
-    new Column(
-        new Column\Name('name'),
+    Column::of(
+        Column\Name::of('name'),
         Column\Type::varchar(),
     ),
 );
@@ -52,34 +52,34 @@ You can specify the primary key of the table like so:
 
 ```php
 $create = CreateTable::named(
-    new Name('users'),
-    new Column(
-        new Column\Name('id'),
+    Name::of('users'),
+    Column::of(
+        Column\Name::of('id'),
         Column\Type::int(),
     ),
 );
-$create = $create->primaryKey(new Column\Name('id'));
+$create = $create->primaryKey(Column\Name::of('id'));
 $connection($create);
 ```
 
 ### Foreign key
 
 ```php
 $create = CreateTable::named(
-    new Name('address'),
-    new Column(
-        new Column\Name('user'),
+    Name::of('address'),
+    Column::of(
+        Column\Name::of('user'),
         Column\Type::int(),
     ),
-    new Column(
-        new Column\Name('address'),
+    Column::of(
+        Column\Name::of('address'),
         Column\Type::text(),
     ),
 );
 $create = $create->foreignKey(
-    new Column\Name('user'),
-    new Name('users'),
-    new Column\Name('id'),
+    Column\Name::of('user'),
+    Name::of('users'),
+    Column\Name::of('id'),
 );
 $connection($create);
 ```

documentation/queries/delete.md

@@ -6,7 +6,7 @@ use Formal\AccessLayer\{
     Table\Name,
 };
 
-$delete = Delete::from(new Name('users'));
+$delete = Delete::from(Name::of('users'));
 $connection($delete);
 ```
 
@@ -38,7 +38,7 @@ final class Username
     }
 }
 
-$delete = Delete::from(new Name('users'))->where(
+$delete = Delete::from(Name::of('users'))->where(
     Username::of('some username')->or(Username::of('other username')),
 );
 $connection($delete);

documentation/queries/drop_table.md

@@ -6,7 +6,7 @@ use Formal\AccessLayer\{
     Table\Name,
 };
 
-$drop = DropTable::named(new Name('users'));
+$drop = DropTable::named(Name::of('users'));
 $connection($drop);
 ```
 
@@ -18,6 +18,6 @@ use Formal\AccessLayer\{
     Table\Name,
 };
 
-$drop = DropTable::ifExists(new Name('users'));
+$drop = DropTable::ifExists(Name::of('users'));
 $connection($drop);
 ```

documentation/queries/insert.md

@@ -9,7 +9,7 @@ use Formal\AccessLayer\{
 };
 
 $insert = Insert::into(
-    new Name('users'),
+    Name::of('users'),
     Row::of([
         'username' => 'some username',
         'name' => 'some name',
@@ -31,15 +31,15 @@ use Formal\AccessLayer\{
 };
 
 $insert = Insert::into(
-    new Name('users'),
-    new Row(
-        new Row\Value(
-            new Column\Name('username'),
+    Name::of('users'),
+    Row::new(
+        Row\Value::of(
+            Column\Name::of('username'),
             'some username',
             Type::string,
         ),
-        new Row\Value(
-            new Column\Name('name'),
+        Row\Value::of(
+            Column\Name::of('name'),
             'some name',
             Type::string,
         ),
@@ -64,9 +64,9 @@ use Formal\AccessLayer\{
 use Innmind\Immutable\Sequence;
 
 $insert = MultipleInsert::into(
-    new Name('users'),
-    new Column\Name('username'),
-    new Column\Name('name'),
+    Name::of('users'),
+    Column\Name::of('username'),
+    Column\Name::of('name'),
 );
 $connection($insert(Sequence::of(
     Row::of([

documentation/queries/select.md

@@ -6,7 +6,7 @@ use Formal\AccesLayer\{
     Table\Name,
 };
 
-$select = Select::from(new Name('users'));
+$select = Select::from(Name::of('users'));
 $users = $connection($select);
 ```
 
@@ -24,9 +24,9 @@ use Formal\AccesLayer\{
     Table\Column,
 };
 
-$select = Select::from(new Name('users'))->columns(
-    new Column\Name('username'),
-    new Column\Name('name'),
+$select = Select::from(Name::of('users'))->columns(
+    Column\Name::of('username'),
+    Column\Name::of('name'),
 );
 $users = $connection($select);
 ```
@@ -58,7 +58,7 @@ final class Username
     }
 }
 
-$select = Select::from(new Name('users'))->where(
+$select = Select::from(Name::of('users'))->where(
     Username::of('some username')->or(Username::of('other username')),
 );
 $users = $connection($select);

documentation/queries/update.md

@@ -8,7 +8,7 @@ use Formal\AccessLayer\{
 };
 
 $update = Update::set(
-    new Name('users'),
+    Name::of('users'),
     Row::of([
         'name' => 'some value',
     ]),
@@ -46,7 +46,7 @@ final class Username
 }
 
 $update = Update::set(
-    new Name('users'),
+    Name::of('users'),
     Row::of([
         'name' => 'some value',
     ]),

fixtures/Table/Column.php

@@ -15,7 +15,7 @@ public static function any(Set $type = null, int $max = null): Set
     {
         return Set\Randomize::of( // randomize to prevent same name used twice
             Set\Composite::immutable(
-                static fn($name, $type): Model => new Model($name, $type),
+                Model::of(...),
                 Column\Name::any($max),
                 $type ?? Column\Type::any(),
             ),

fixtures/Table/Name.php

@@ -14,7 +14,7 @@ final class Name
     public static function any(): Set
     {
         return Set\Composite::immutable(
-            static fn(string $firstChar, string $name): Model => new Model($firstChar.$name),
+            static fn(string $firstChar, string $name): Model => Model::of($firstChar.$name),
             Set\Either::any( // table name can't start with a number
                 Set\Chars::lowercaseLetter(),
                 Set\Chars::uppercaseLetter(),

proofs/connection/lazy.php

@@ -12,7 +12,7 @@
 
 return static function() {
     $port = \getenv('DB_PORT') ?: '3306';
-    $connection = new Lazy(
+    $connection = Lazy::of(
         static fn() => PDO::of(Url::of("mysql://root:[email protected]:$port/example")),
     );
     Properties::seed($connection);
@@ -32,7 +32,7 @@
     yield test(
         'Lazy connection must not be established at instanciation',
         static fn($assert) => $assert
-            ->object(new Lazy(static fn() => PDO::of(Url::of('mysql://unknown:[email protected]:3306/unknown'))))
+            ->object(Lazy::of(static fn() => PDO::of(Url::of('mysql://unknown:[email protected]:3306/unknown'))))
             ->instance(Connection::class),
     );