Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix capabilities for orm #10

Merged
merged 4 commits into from
Jul 14, 2024
Merged

Fix capabilities for orm #10

merged 4 commits into from
Jul 14, 2024

Conversation

Baptouuuu
Copy link
Member

Problem

When trying to update the ORM to version 3 of this package it revealed:

  • deleting with an aliased table doesn't work
  • joins when deleting are used by the ORM

Solution

  • Removes support for SQLite as it doesn't support table alias and joins when deleting
  • Fix table aliasing when deleting
  • Reintroduce Delete::join()

@Baptouuuu Baptouuuu added the bug Something isn't working label Jul 14, 2024
@Baptouuuu Baptouuuu self-assigned this Jul 14, 2024
Copy link

codecov bot commented Jul 14, 2024

Codecov Report

Attention: Patch coverage is 96.62162% with 5 lines in your changes missing coverage. Please review.

Project coverage is 97.28%. Comparing base (8264837) to head (caed645).
Report is 3 commits behind head on develop.

Files Patch % Lines
src/Query/Delete.php 93.15% 5 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop      #10      +/-   ##
=============================================
- Coverage      97.35%   97.28%   -0.07%     
- Complexity       291      324      +33     
=============================================
  Files             38       38              
  Lines           1926     2210     +284     
=============================================
+ Hits            1875     2150     +275     
- Misses            51       60       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Baptouuuu Baptouuuu merged commit 55d6577 into develop Jul 14, 2024
26 of 28 checks passed
@Baptouuuu Baptouuuu deleted the fix-capabilities-for-orm branch July 14, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant