Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mbedtls windows ready, force CLANG on sgx, rearrange CI scripts #234

Merged
merged 10 commits into from
Sep 14, 2023

Conversation

kwakkel1000
Copy link
Contributor

@kwakkel1000 kwakkel1000 commented Mar 20, 2023

We have fixes in CLANG for SGX, so now we force that you use CLANG if you compile for SGX.
We can now compile mbedtls on windows (with CI checked)
CI scripts are restructured for better understanding.

mbedtls-sys/build/features.rs Outdated Show resolved Hide resolved
mbedtls/src/lib.rs Outdated Show resolved Hide resolved
mbedtls/src/lib.rs Outdated Show resolved Hide resolved
@kwakkel1000 kwakkel1000 force-pushed the gijsk/windows branch 2 times, most recently from 348e493 to 745c2a4 Compare March 20, 2023 15:32
Copy link
Collaborator

@Taowyoo Taowyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Be free to merge it after tested with our internal dependents

@Taowyoo Taowyoo marked this pull request as draft September 6, 2023 02:47
@Taowyoo Taowyoo force-pushed the gijsk/windows branch 3 times, most recently from f53f25c to b4e0bcc Compare September 8, 2023 21:33
@Taowyoo Taowyoo marked this pull request as ready for review September 8, 2023 23:38
@Taowyoo Taowyoo changed the title Make mbedtls windows ready, export mbedtls sys items, force CLANG on sgx Make mbedtls windows ready, force CLANG on sgx, rearrange CI scripts Sep 10, 2023
ci.sh Outdated Show resolved Hide resolved
mbedtls-platform-support/src/rust_printf.c Show resolved Hide resolved
@Taowyoo
Copy link
Collaborator

Taowyoo commented Sep 14, 2023

bors ping

@bors
Copy link
Contributor

bors bot commented Sep 14, 2023

pong

@Taowyoo
Copy link
Collaborator

Taowyoo commented Sep 14, 2023

bors r=[arai-fortanix]

bors bot added a commit that referenced this pull request Sep 14, 2023
234: Make mbedtls windows ready, force CLANG on sgx, rearrange CI scripts r=[arai-fortanix] a=kwakkel1000

We have fixes in CLANG for SGX, so now we force that you use CLANG if you compile for SGX.
We can now compile mbedtls on windows (with CI checked)
CI scripts are restructured for better understanding.

Co-authored-by: Gijs Kwakkel <[email protected]>
Co-authored-by: Yuxiang Cao <[email protected]>
Co-authored-by: YxC <[email protected]>
Co-authored-by: YX Cao <[email protected]>
@bors
Copy link
Contributor

bors bot commented Sep 14, 2023

Build failed:

bors bot added a commit that referenced this pull request Sep 14, 2023
314: back port #234 to v0.9 r=[arushi-pahuja] a=Taowyoo



Co-authored-by: Gijs Kwakkel <[email protected]>
Co-authored-by: Yuxiang Cao <[email protected]>
Co-authored-by: YX Cao <[email protected]>
@Taowyoo
Copy link
Collaborator

Taowyoo commented Sep 14, 2023

bors r=[arai-fortanix]

@bors
Copy link
Contributor

bors bot commented Sep 14, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

  • ci

@bors bors bot merged commit 52476ee into master Sep 14, 2023
9 checks passed
@Taowyoo Taowyoo deleted the gijsk/windows branch September 14, 2023 19:03
bors bot added a commit that referenced this pull request Sep 14, 2023
314: back port #234 to v0.9 r=[arushi-pahuja] a=Taowyoo



Co-authored-by: Gijs Kwakkel <[email protected]>
Co-authored-by: Yuxiang Cao <[email protected]>
Co-authored-by: YX Cao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants