Group 5: Pullrequest for refactoring excersice Day2 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| elif self._book_type == "Audio": | ||
| return self.duration | ||
| if self._book_type in self._booktype_duration.keys(): | ||
| return self._booktype_duration[self._book_type] |
| @staticmethod | ||
| def find_book(self,book_copy: "BookCopy") -> "Book": | ||
| for book in self.Books.Book: | ||
| if(book.__eq__(book,book_copy)): |
| discount_count: int = max(0, len(self.books) - self.min_books_for_discount) | ||
| discount: float = discount_count * self.discount_per_book | ||
| discount += current_reading_credits * self.discount_per_reading_credit | ||
| final_price = price - discount |
There was a problem hiding this comment.
Nice but could be broken down even further (e.g., dedicated function/method) :)
| borrowed_book.existing_items, | ||
| borrowed_book.borrowed_items, | ||
| borrowed_book._book_type | ||
| borrowed_book.genres | ||
| ) | ||
| return book | ||
|
|
||
| def can_borrow(self) -> bool: | ||
| if self._book_type == "Paper": |
There was a problem hiding this comment.
Why not a dict here? Seems like a mix of if-else statements and dict lookups.
| elif self._book_type == "Audio": | ||
| return 2 | ||
| if(self._book_type in self._booktype_fee.keys()): | ||
| return self._booktype_fee[self._book_type] | ||
| else: | ||
| raise AttributeError("No such book type...") |
There was a problem hiding this comment.
Redundant, no? A failed dict lookup will raise a KeyError. Maybe you can let it propagate.
dejavu9127
reviewed
Nov 23, 2023
| @@ -155,3 +156,10 @@ def delete_invoice(invoice: Invoice): | |||
| index = invoices.index(invoice) | |||
| if index >= 0: | |||
| invoices.remove(invoice) | |||
|
|
|||
| @staticmethod | |||
| def find_book(self,book_copy: "BookCopy") -> "Book": | |||
There was a problem hiding this comment.
Suggested change
| def find_book(self,book_copy: "BookCopy") -> "Book": | |
| def find_book(self,book_copy: "BookCopy") -> "Book": |
Not sure if you can pass self as input argument to static method. Maybe Maintain an Inventory class, and pass as input arg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have changed some things in files "books","users" and "invoice".