Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implemented package specific token uploads #31

Merged
merged 5 commits into from
May 21, 2023
Merged

feat: implemented package specific token uploads #31

merged 5 commits into from
May 21, 2023

Conversation

arteevraina
Copy link
Member

@arteevraina arteevraina commented May 5, 2023 •
edited
Loading

Addresses: #19 (comment)

  • Added API to create token specific to a package.
  • Allow upload of package from package tokens.
  • Added UI + actions for generate token for the packages.
  • Checks for verifying namespace admins, namespace maintainers & package maintainers for the upload of the packages.
  • Show generate token button for packages only to package maintainer.

@arteevraina arteevraina requested a review from henilp105 May 5, 2023 19:07
henilp105
henilp105 approved these changes May 6, 2023
View reviewed changes
Copy link
Member

@henilp105 henilp105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arteevraina , Looks good to me.

@arteevraina arteevraina marked this pull request as draft May 7, 2023 05:41
@arteevraina
Copy link
Member Author

Testable link - https://registry-frontend-arteevraina.vercel.app/

Make sure to clear cookies for this url as well.

@henilp105 @perazz @minhqdao

@arteevraina arteevraina marked this pull request as ready for review May 16, 2023 16:36
@henilp105
Copy link
Member

Thanks @arteevraina , Looks good to me.

@henilp105 henilp105 merged commit 4a0d9c2 into fortran-lang:main May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henilp105 henilp105 henilp105 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arteevraina @henilp105