-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API for deleting package. #9
Conversation
@arteevraina I had considered |
1 similar comment
@arteevraina I had considered |
To answer your question: The ideal case would be that PRs are quickly merged into main and new PRs are also opened and merged against main. That and keeping PR sizes small should result in a small number of merge conflicts and short development cycles. |
@arteevraina I have made the flask code modular which would make it easy to add new features/commits and also prevent (mostly) the merge conflicts. |
08451f9
to
9c639ca
Compare
9c639ca
to
fe0229c
Compare
def delete_package(username, namespace_name, package_name): | ||
uuid = request.cookies.get("uuid") | ||
if not uuid: | ||
return render_template("login.html") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arteevraina We would have to add a json response of unauthorized 403, as we have shifted to react/next.js frontend and for CLI application.
76bd6a9
to
691a786
Compare
fix: persist state after page reload
I have created the PR for initializing the API for deleting a package. Though, I have not used the original API route that was discussed in #5 .
I had an idea to use this route.
instead of
because I was doubtful that
_id
of the mongo DB document would be correctly sent by the URL.Commits to review:
@henilp105 @minhqdao @perazz @fortran-lang/fpm I have few questions here, Since we have nothing merged in the main branch as of today And this PR contains changes made by @henilp105 as well since the start of project. Should I consider creating this PR to the henils remote branch and can be reviewed there as of now because it will be easier to review then.