Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to new timezone database #81

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open
  •  
  •  
  •  
14 changes: 13 additions & 1 deletion .github/workflows/sugar_unit_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,24 @@ jobs:
steps:
- uses: actions/checkout@v4
- uses: subosito/[email protected]
- name: Install Node
uses: actions/setup-node@v4
with:
node-version: "20"
- name: Install Java
uses: actions/setup-java@v4
with:
distribution: "adopt"
java-version: "11.0.26+4"
dickermoshe marked this conversation as resolved.
Show resolved Hide resolved
- name: Set up Maven
uses: stCarolas/setup-maven@v5
dickermoshe marked this conversation as resolved.
Show resolved Hide resolved
- run: dart pub get
- run: dart run tool/generate_timezones.dart
- run: dart analyze --fatal-warnings
- run: dart run coverage:test_with_coverage
- run: sudo apt-get update -y
- run: sudo apt-get install -y lcov
- run: lcov --remove ./coverage/lcov.info '**.g.dart' -o ./coverage/lcov.info
- uses: codecov/codecov-action@v5
with:
files: ./sugar/coverage/lcov.info
files: ./sugar/coverage/lcov.info
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@ import 'package:test/test.dart';
/// These tests should be ran using the shell/bat scripts in the same folder.
void main() {
test('defaultPlatformTimezoneProvider() return current timezone', () {
final timezones = DefaultTimezoneProvider();
final timezones = EmbeddedTimezoneProvider();
final timezone = defaultPlatformTimezoneProvider();

expect(timezones.containsKey(timezone), true);
expect(timezone, isNot('Factory'));
}, testOn: 'windows');

test('defaultPlatformTimezoneProvider() return current timezone', () {
final timezones = DefaultTimezoneProvider();
final timezones = EmbeddedTimezoneProvider();
final timezone = defaultPlatformTimezoneProvider();

expect(timezones.containsKey(timezone), true);
Expand All @@ -21,15 +21,16 @@ void main() {

group('posix', () {
test('defaultPlatformTimezoneProvider() known TZ environment variable', () {
final timezones = DefaultTimezoneProvider();
final timezones = EmbeddedTimezoneProvider();
final timezone = defaultPlatformTimezoneProvider();

expect(timezones.containsKey(timezone), true);
expect(timezone, 'Mexico/BajaSur');
});

test('defaultPlatformTimezoneProvider() unknown TZ environment variable', () {
final timezones = DefaultTimezoneProvider();
test('defaultPlatformTimezoneProvider() unknown TZ environment variable',
() {
final timezones = EmbeddedTimezoneProvider();
final timezone = defaultPlatformTimezoneProvider();

expect(timezones.containsKey(timezone), true);
Expand Down
143 changes: 0 additions & 143 deletions sugar/lib/src/time/zone/dynamic_timezone.dart

This file was deleted.

32 changes: 0 additions & 32 deletions sugar/lib/src/time/zone/fixed_timezone.dart

This file was deleted.

Loading
Loading