-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rating link on Apple Store goes to Android #1172 #1217
fix: rating link on Apple Store goes to Android #1172 #1217
Conversation
Reviewer's Guide by SourceryThe pull request fixes an issue where the 'Rate Us' link in the navigation drawer was directing iOS users to the Google Play Store. The link has been updated to redirect iOS users to the app's page on the Apple App Store. Sequence diagram for Rate Us link redirectionsequenceDiagram
participant User
participant BMDrawer
participant Platform
participant AppStore
participant PlayStore
User->>BMDrawer: Clicks 'Rate Us' in navigation drawer
BMDrawer->>Platform: Checks Platform.isIOS
alt Platform.isIOS == true
Platform-->>BMDrawer: true
BMDrawer->>AppStore: Navigates to Apple App Store
else Platform.isIOS == false
Platform-->>BMDrawer: false
BMDrawer->>PlayStore: Navigates to Google Play Store
end
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @samruddhi-Rahegaonkar - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Build successful. APKs to test: https://github.com/fossasia/badgemagic-app/actions/runs/13617443197/artifacts/2677805048 |
Fixes #1172
Changes
Screenshots / Recordings
Checklist:
constants.dart
without hard coding any value.Summary by Sourcery
Bug Fixes: