Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rating link on Apple Store goes to Android #1172 #1217

Merged
merged 1 commit into from
Mar 2, 2025

Conversation

samruddhi-Rahegaonkar
Copy link
Contributor

@samruddhi-Rahegaonkar samruddhi-Rahegaonkar commented Mar 2, 2025

Fixes #1172

Changes

Screenshots / Recordings

Checklist:

  • [x ] No hard coding: I have used resources from constants.dart without hard coding any value.
  • [x ] No end of file edits: No modifications done at end of resource files.
  • [x ] Code reformatting: I have reformatted code and fixed indentation in every file included in this pull request.
  • [x ] Code analyzation: My code passes analyzations run in flutter analyze and tests run in flutter test.

Summary by Sourcery

Bug Fixes:

  • Fixes the rating link in the navigation drawer to redirect iOS users to the Apple App Store.

Copy link
Contributor

sourcery-ai bot commented Mar 2, 2025

Reviewer's Guide by Sourcery

The pull request fixes an issue where the 'Rate Us' link in the navigation drawer was directing iOS users to the Google Play Store. The link has been updated to redirect iOS users to the app's page on the Apple App Store.

Sequence diagram for Rate Us link redirection

sequenceDiagram
    participant User
    participant BMDrawer
    participant Platform
    participant AppStore
    participant PlayStore

    User->>BMDrawer: Clicks 'Rate Us' in navigation drawer
    BMDrawer->>Platform: Checks Platform.isIOS
    alt Platform.isIOS == true
        Platform-->>BMDrawer: true
        BMDrawer->>AppStore: Navigates to Apple App Store
    else Platform.isIOS == false
        Platform-->>BMDrawer: false
        BMDrawer->>PlayStore: Navigates to Google Play Store
    end
Loading

File-Level Changes

Change Details Files
The app store link was updated to navigate users to the correct store based on their platform.
  • Added a conditional check for the operating system.
  • If the operating system is iOS, the link navigates to the Apple App Store.
  • If the operating system is not iOS, the link navigates to the Google Play Store.
lib/view/widgets/navigation_drawer.dart

Assessment against linked issues

Issue Objective Addressed Explanation
#1172 The rate us link in the iOS version of the app should direct users to the correct Apple Store page for rating the app.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @samruddhi-Rahegaonkar - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@samruddhi-Rahegaonkar samruddhi-Rahegaonkar changed the title feat:Fixed Rating Link on Apple Store goes to Android #1172 fix:Fixed Rating Link on Apple Store goes to Android #1172 Mar 2, 2025
@adityastic adityastic enabled auto-merge (squash) March 2, 2025 16:11
@adityastic adityastic changed the title fix:Fixed Rating Link on Apple Store goes to Android #1172 fix: Fixed Rating Link on Apple Store goes to Android #1172 Mar 2, 2025
@adityastic adityastic disabled auto-merge March 2, 2025 16:11
@adityastic adityastic enabled auto-merge (squash) March 2, 2025 16:12
Copy link

github-actions bot commented Mar 2, 2025

@adityastic adityastic changed the title fix: Fixed Rating Link on Apple Store goes to Android #1172 fix: rating link on Apple Store goes to Android #1172 Mar 2, 2025
@adityastic adityastic disabled auto-merge March 2, 2025 16:52
@adityastic adityastic enabled auto-merge (squash) March 2, 2025 16:52
@adityastic adityastic merged commit 0612802 into fossasia:flutter_app Mar 2, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rating Link on Apple Store goes to Android
2 participants