-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create docs deploy workflow #304
Conversation
Reviewer's Guide by SourceryThis pull request introduces a new GitHub Actions workflow to automatically build and deploy the Sphinx documentation to the gh-pages branch. It also adds a CNAME file to the root directory. Sequence diagram for documentation deployment workflowsequenceDiagram
participant GH as GitHub Repository
participant WF as GitHub Workflow
participant Py as Python Environment
participant Doc as Sphinx Docs
participant GP as GitHub Pages
Note over GH: Push to development branch
GH->>WF: Trigger workflow
WF->>GH: Checkout repository
WF->>Py: Setup Python 3.11
WF->>Py: Install dependencies
Py->>Doc: Build HTML documentation
WF->>GP: Deploy to gh-pages branch
Note over GP: Documentation live
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @r3yc0n1c - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider triggering the documentation deployment from the main/master branch instead of development to ensure published docs match the stable version of the codebase.
- The CNAME file appears to be empty - it should contain the custom domain name if you're planning to use a custom domain for GitHub Pages.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
fixes #300
Screenshot
Summary
Summary by Sourcery
Set up automatic deployment of Sphinx documentation to GitHub Pages on the
gh-pages
branch from thedevelopment
branch.CI:
development
branch.Deployment:
gh-pages
branch.