Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #604 Handles orientation change in Memory Graph Activity #605

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Fixes #604 Handles orientation change in Memory Graph Activity #605

wants to merge 1 commit into from

Conversation

AkshobhyaP
Copy link
Member

Fixes #604

Changes:
Handled Orientation change in Memory Graph activity .Now the slected fragment is retained after orientation change.

Screenshot/s for the changes:
20200126_222945

Checklist:

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

APK for testing:
feature.zip

@jddeep
Copy link
Member

jddeep commented Jan 29, 2020

@AkshobhyaP Please squash your commits into one.

jddeep
jddeep suggested changes Jan 29, 2020
View reviewed changes
app/src/main/java/io/neurolab/activities/MemoryGraphParent.java Outdated
@@ -49,12 +50,11 @@ protected void onCreate(Bundle savedInstanceState) {
selectedFragment.setArguments(bundle);
FragmentTransaction transaction = getSupportFragmentManager().beginTransaction();
transaction.replace(R.id.frame_layout, selectedFragment);
defaultProgram=selectedFragment;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reformat code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityastic adityastic Awaiting requested review from adityastic

@jddeep jddeep Awaiting requested review from jddeep

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Orientation change in Memory Graph.
2 participants
@AkshobhyaP @jddeep