Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added developers section #613

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

991rajat
Copy link

Fixes #609

Screenshot/s for the changes:
GIF-200129_190311

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

APK
app-debug.zip

@auto-label auto-label bot added the feature New addition to the existing app label Jan 29, 2020
@dipu989
Copy link
Contributor

dipu989 commented Jan 31, 2020

@991rajat Feature looks good! Just a suggestion, the developer's section would look great below Version. That section is reserved mainly for different fossasia channels and links.

Copy link
Member

@jddeep jddeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a matching icon according to the item added

@991rajat
Copy link
Author

991rajat commented Feb 1, 2020

Screenshot_20200201-113747

@991rajat 991rajat requested a review from jddeep February 1, 2020 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New addition to the existing app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add developers section in about us
3 participants