Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Issue #626: Add Dark Mode #704

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

Samyakjain003
Copy link

@Samyakjain003 Samyakjain003 commented Aug 30, 2021

Fixed Issue #626

Changes: Add Dark Mode to the App.

Screenshot/s for the changes:
Screenshot 2021-08-31 at 12 08 53 AM
Screenshot 2021-08-31 at 12 09 13 AM
Screenshot 2021-08-31 at 12 09 48 AM
Screenshot 2021-08-31 at 12 09 31 AM
Screenshot 2021-08-31 at 12 10 14 AM
Screenshot 2021-08-31 at 12 10 26 AM

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

APK for testing:
DarkMode.zip

@Samyakjain003 Samyakjain003 changed the title Issue #626 Fixed Issue #626: Add Dark Mode Aug 30, 2021
@CloudyPadmal
Copy link
Contributor

Thank you @Samyakjain003 for your effort. There are couple of CSV files got edited. Could you please check and revert them?

@Samyakjain003
Copy link
Author

Thank you @Samyakjain003 for your effort. There are couple of CSV files got edited. Could you please check and revert them?

Updated all the required changes in CSV files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants