Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix:2188 Fixing Generate Config File layout #2216

Closed
wants to merge 3 commits into from
Closed

Fix:2188 Fixing Generate Config File layout #2216

wants to merge 3 commits into from

Conversation

kartikeysaran
Copy link
Contributor

@kartikeysaran kartikeysaran commented May 12, 2021 •
edited
Loading

Fixes #2188
Fixes #2181

Changes: Using ConstraintLayout and Margins to Fix the Generate Config File Layout
This works on devices of all sizes
Screenshot/s for the changes:

Checklist:

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

kartikaysharma01
kartikaysharma01 reviewed May 23, 2021
View reviewed changes
app/src/main/res/layout/activity_create_config.xml
Comment on lines 47 to 49
android:layout_width="@dimen/width_zero"
android:layout_weight="@dimen/weight_two"
android:layout_height="wrap_content"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the lines off your PR if they are not being used in the code anymore

kartikaysharma01
kartikaysharma01 reviewed May 23, 2021
View reviewed changes
app/src/main/res/layout/activity_create_config.xml
Comment on lines 88 to 90
android:layout_width="@dimen/width_zero"
android:layout_weight="@dimen/weight_one"
android:layout_height="wrap_content"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the lines off your PR if they are not being used in the code anymore

@kartikaysharma01
Copy link
Member

@kartikeysaran I am sorry but the solution either seems to be device specific or incomplete. Can you please share the screenshot for Barometer instrument as per your fix

@kartikaysharma01
Copy link
Member

@kartikeysaran Also please refer issue #2208 . There is already a PR for that.

@kartikeysaran
Copy link
Contributor Author

@kartikeysaran I am sorry but the solution either seems to be device specific or incomplete. Can you please share the screenshot for Barometer instrument as per your fix

Please have a look i am using contraint layout and i can share screenshot for each device it works fine with all

@CloudyPadmal
Copy link
Collaborator

Thanks for the PR @kartikeysaran . But let's go with the card layout.

@kartikeysaran
Copy link
Contributor Author

Thanks for the PR @kartikeysaran . But let's go with the card layout.

Should i update the pr with Card Layout ?

@CloudyPadmal
Copy link
Collaborator

#2210 did that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartikaysharma01 kartikaysharma01 kartikaysharma01 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Time interval units are not shown to the user. "Generate Config Files" layout is not uniform.
3 participants
@kartikeysaran @kartikaysharma01 @CloudyPadmal