Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: made the phase buttons invisible for Analog Wave 1 and Digital Wave SQR1 #2452

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

AsCress
Copy link
Collaborator

@AsCress AsCress commented May 31, 2024

Fixes #2444
Toggles the visibility of the phase buttons to set them to INVISIBLE for Analog Wave 1 and Digital Wave SQR1 as a phase change for these waves isn't supported by our hardware.

Changes

  • app/src/main/java/io/pslab/activity/WaveGeneratorActivity.java

Screenshots / Recordings

Here are screenshots showing the screen when Analog Wave 1 and Digital Wave SQR1 are selected.

Screenshot_20240531_142450

Screenshot_20240531_142530

Checklist:

  • No hard coding: I have used resources from strings.xml, dimens.xml and colors.xml without hard coding any value.
  • No end of file edits: No modifications done at end of resource files strings.xml, dimens.xml or colors.xml.
  • Code reformatting: I have reformatted code and fixed indentation in every file included in this pull request.
  • No extra space: My code does not contain any extra lines or extra spaces than the ones that are necessary.

@mariobehling mariobehling merged commit 4a1e68a into fossasia:development Jun 1, 2024
2 checks passed
@AsCress AsCress deleted the issue2444 branch June 3, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wave Generator: phase cannot be selected for first waveform
2 participants