-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: updated pull-request workflow to build debug APK #2607
Conversation
Reviewer's Guide by SourceryThis pull request updates the Android build workflow to generate debug APKs instead of release APKs. This allows contributors to test the app on their devices without signing the APK. Sequence diagram for updated Android build workflow on pull requestssequenceDiagram
participant PR as Pull Request
participant GH as GitHub Actions
participant FB as Flutter Build
participant A as Artifacts
PR->>GH: Trigger workflow
GH->>FB: Build debug APK
Note over FB: --debug flag added
FB-->>GH: Generate debug APK
GH->>A: Upload APK artifact
Note over A: Only debug APK stored
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @AsCress - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
28140c9
to
36efc54
Compare
Build successful. APKs to test: https://github.com/fossasia/pslab-android/actions/runs/12643222922/artifacts/2393302386 |
36efc54
to
9f07c48
Compare
I guess we should follow the same procedure that we do for the native app. Build debug APKs on pull requests and release APKs and bundles on push-events.
Currently, we are building release APKs on pull requests, which can't be installed on devices since we aren't signing them, and hence can't be tested by contributors.
Screenshots / Recordings
N/A
Checklist:
strings.xml
,dimens.xml
andcolors.xml
without hard coding any value.strings.xml
,dimens.xml
orcolors.xml
.Summary by Sourcery
Build debug APKs instead of release APKs for pull requests to allow testing on contributor devices.
Enhancements:
CI: