Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updated pull-request workflow to build debug APK #2607

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

AsCress
Copy link
Collaborator

@AsCress AsCress commented Jan 6, 2025

I guess we should follow the same procedure that we do for the native app. Build debug APKs on pull requests and release APKs and bundles on push-events.
Currently, we are building release APKs on pull requests, which can't be installed on devices since we aren't signing them, and hence can't be tested by contributors.

Screenshots / Recordings

N/A

Checklist:

  • No hard coding: I have used resources from strings.xml, dimens.xml and colors.xml without hard coding any value.
  • No end of file edits: No modifications done at end of resource files strings.xml, dimens.xml or colors.xml.
  • Code reformatting: I have reformatted code and fixed indentation in every file included in this pull request.
  • No extra space: My code does not contain any extra lines or extra spaces than the ones that are necessary.

Summary by Sourcery

Build debug APKs instead of release APKs for pull requests to allow testing on contributor devices.

Enhancements:

  • Store only the debug APK as an artifact.

CI:

  • Build debug APKs in the Android build workflow.

@AsCress AsCress added the Chore Changes to things that do not go into production label Jan 6, 2025
@AsCress AsCress requested a review from adityastic January 6, 2025 06:07
@AsCress AsCress self-assigned this Jan 6, 2025
Copy link

sourcery-ai bot commented Jan 6, 2025

Reviewer's Guide by Sourcery

This pull request updates the Android build workflow to generate debug APKs instead of release APKs. This allows contributors to test the app on their devices without signing the APK.

Sequence diagram for updated Android build workflow on pull requests

sequenceDiagram
    participant PR as Pull Request
    participant GH as GitHub Actions
    participant FB as Flutter Build
    participant A as Artifacts

    PR->>GH: Trigger workflow
    GH->>FB: Build debug APK
    Note over FB: --debug flag added
    FB-->>GH: Generate debug APK
    GH->>A: Upload APK artifact
    Note over A: Only debug APK stored
Loading

File-Level Changes

Change Details Files
Build debug APKs instead of release APKs
  • Removed the release APK and appbundle build steps.
  • Added a debug APK build step.
  • Updated the upload artifact step to only store the debug APK file
.github/actions/android/action.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @AsCress - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

github-actions bot commented Jan 6, 2025

@AsCress AsCress enabled auto-merge (squash) January 6, 2025 06:33
@AsCress AsCress force-pushed the flutter-workflows branch from 36efc54 to 9f07c48 Compare January 7, 2025 01:09
@AsCress AsCress merged commit 043618e into fossasia:flutter Jan 12, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore Changes to things that do not go into production
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants