Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump androidx.recyclerview:recyclerview from 1.3.2 to 1.4.0 #2617

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

AsCress
Copy link
Collaborator

@AsCress AsCress commented Jan 22, 2025

Superseeds #2616.

Changes

  • Bumps androidx.recyclerview:recyclerview from 1.3.2 to 1.4.0.
  • Changes the compileSdk to 35.
  • Also, changes the targetSdk to 35. We were targeting 34 before, which has now been declared as the minimum API level that an app should target, to stay on the PlayStore.

Screenshots / Recordings

N/A

Checklist:

  • No hard coding: I have used resources from strings.xml, dimens.xml and colors.xml without hard coding any value.
  • No end of file edits: No modifications done at end of resource files strings.xml, dimens.xml or colors.xml.
  • Code reformatting: I have reformatted code and fixed indentation in every file included in this pull request.
  • No extra space: My code does not contain any extra lines or extra spaces than the ones that are necessary.

@marcnause API level 34 -> 35 introduces many changes. I tested the app once but couldn't find anything that breaks our app. It'd be great if you could test the whole app once before merging this PR.

Summary by Sourcery

Update Android compile and target SDK versions to 35 and bump androidx.recyclerview library to 1.4.0.

Build:

  • Bump androidx.recyclerview from 1.3.2 to 1.4.0.
  • Change compileSdk to 35.
  • Change targetSdk to 35.

@AsCress AsCress added Chore Changes to things that do not go into production Dependencies Adding dependencies and libraries java Pull requests that update Java code labels Jan 22, 2025
@AsCress AsCress self-assigned this Jan 22, 2025
Copy link

sourcery-ai bot commented Jan 22, 2025

Reviewer's Guide by Sourcery

This pull request upgrades the target SDK to 35, the compile SDK to 35 and the RecyclerView library to 1.4.0. The target SDK upgrade is necessary to comply with the Play Store's new requirements.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated the target and compile SDK versions to 35.
  • Changed compileSdk from 34 to 35.
  • Changed targetSdk from 34 to 35.
app/build.gradle.kts
Updated the RecyclerView library to version 1.4.0.
  • Changed androidx.recyclerview:recyclerview from 1.3.2 to 1.4.0.
app/build.gradle.kts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @AsCress - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

github-actions bot commented Jan 22, 2025

Build failed

@AsCress AsCress enabled auto-merge (squash) January 22, 2025 17:12
@marcnause
Copy link
Contributor

@AsCress, the app worked fine for me.

@AsCress AsCress merged commit 98445e1 into fossasia:development Jan 23, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore Changes to things that do not go into production Dependencies Adding dependencies and libraries java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants