Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: setup iOS pipeline #2622

Merged
merged 1 commit into from
Feb 2, 2025
Merged

Conversation

AsCress
Copy link
Collaborator

@AsCress AsCress commented Jan 24, 2025

Sets up the iOS pipeline for our flutter app.

Screenshots / Recordings

N/A

Checklist:

  • No hard coding: I have used resources from strings.xml, dimens.xml and colors.xml without hard coding any value.
  • No end of file edits: No modifications done at end of resource files strings.xml, dimens.xml or colors.xml.
  • Code reformatting: I have reformatted code and fixed indentation in every file included in this pull request.
  • No extra space: My code does not contain any extra lines or extra spaces than the ones that are necessary.

@adityastic Haven't made any changes to Info.plist yet, because I'm not sure about iOS permissions yet. Currently, the app is in the development stage and doesn't require any explicit permissions as of such. Maybe we can set them up at a later stage ?

Summary by Sourcery

Set up the iOS CI pipeline to build and deploy the app to TestFlight.

Enhancements:

  • Update iOS project settings and assets.

CI:

  • Add a workflow to build and deploy iOS apps.
  • Set up code signing and certificates for iOS builds.
  • Build iOS IPA with code signing for pushes to the "flutter" branch and without code signing for pull requests.

@AsCress AsCress added Chore Changes to things that do not go into production flutter labels Jan 24, 2025
@AsCress AsCress requested a review from adityastic January 24, 2025 11:15
@AsCress AsCress self-assigned this Jan 24, 2025
Copy link

sourcery-ai bot commented Jan 24, 2025

Reviewer's Guide by Sourcery

This pull request sets up the iOS pipeline for the flutter app. It includes changes to the github workflow, the iOS action, and some minor changes to the android and ios project files.

Flow diagram for iOS build process

flowchart TD
    Start[Start Build] --> Check{Check Event Type}
    Check -->|Pull Request| NoCert[Build without Code Signing]
    Check -->|Push to flutter branch| Auth[Setup Certificates]
    Auth --> Cert[Build with Code Signing]
    Cert --> Upload[Upload to TestFlight]
    NoCert --> End[End Build]
    Upload --> End
Loading

File-Level Changes

Change Details Files
Added a new job to the push workflow to build and deploy the iOS app.
  • Added a new job named 'ios' to the push workflow.
  • Added a step to prepare the iOS key.
  • Added a step to setup certificates.
  • Added a step to run the iOS workflow action.
  • Added a step to push the app to testflight.
.github/workflows/push-event.yml
Modified the iOS action to build the IPA with or without code signing based on the event type.
  • Added a conditional step to build the IPA without code signing for pull requests.
  • Added a conditional step to build the IPA with code signing for other events.
.github/actions/ios/action.yml
Updated the android manifest to use the correct launcher icon.
  • Changed the icon attribute to use the correct launcher icon.
android/app/src/main/AndroidManifest.xml
Added gitignore files for android and ios.
  • Added a gitignore file for android.
  • Added a gitignore file for ios.
android/.gitignore
ios/.gitignore
Updated the ios project file.
  • Updated the ios project file.
ios/Runner.xcodeproj/project.pbxproj
Updated the ios app icon configuration.
  • Updated the ios app icon configuration.
ios/Runner/Assets.xcassets/AppIcon.appiconset/Contents.json
Updated the pubspec lock file.
  • Updated the pubspec lock file.
pubspec.lock

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @AsCress - I've reviewed your changes and found some issues that need to be addressed.

Blocking issues:

  • Missing implementation for code signing build step (link)

Overall Comments:

  • The iOS IPA build with code signing section is empty - please add the appropriate flutter build command for signed builds
Here's what I looked at during the review
  • 🔴 General issues: 1 blocking issue
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

.github/actions/ios/action.yml Show resolved Hide resolved
Copy link

github-actions bot commented Jan 24, 2025

@AsCress AsCress force-pushed the iOS-pipeline branch 5 times, most recently from 185b3a6 to a35b39d Compare January 25, 2025 05:12
@adityastic adityastic merged commit 304ee4b into fossasia:flutter Feb 2, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore Changes to things that do not go into production flutter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants