-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: setup iOS pipeline #2622
Conversation
Reviewer's Guide by SourceryThis pull request sets up the iOS pipeline for the flutter app. It includes changes to the github workflow, the iOS action, and some minor changes to the android and ios project files. Flow diagram for iOS build processflowchart TD
Start[Start Build] --> Check{Check Event Type}
Check -->|Pull Request| NoCert[Build without Code Signing]
Check -->|Push to flutter branch| Auth[Setup Certificates]
Auth --> Cert[Build with Code Signing]
Cert --> Upload[Upload to TestFlight]
NoCert --> End[End Build]
Upload --> End
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @AsCress - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
- Missing implementation for code signing build step (link)
Overall Comments:
- The iOS IPA build with code signing section is empty - please add the appropriate flutter build command for signed builds
Here's what I looked at during the review
- 🔴 General issues: 1 blocking issue
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Build successful. APKs to test: https://github.com/fossasia/pslab-android/actions/runs/12962098924/artifacts/2484498091 |
185b3a6
to
a35b39d
Compare
Sets up the iOS pipeline for our flutter app.
Screenshots / Recordings
N/A
Checklist:
strings.xml
,dimens.xml
andcolors.xml
without hard coding any value.strings.xml
,dimens.xml
orcolors.xml
.@adityastic Haven't made any changes to Info.plist yet, because I'm not sure about iOS permissions yet. Currently, the app is in the development stage and doesn't require any explicit permissions as of such. Maybe we can set them up at a later stage ?
Summary by Sourcery
Set up the iOS CI pipeline to build and deploy the app to TestFlight.
Enhancements:
CI: