-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues number 5 and 6 mainly #8
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nyedidikeke
commented
Jan 26, 2020
•
edited
Loading
edited
- Build Component (Footer)
- Build Header Component (Navigation)
- Add Header Component (hero section)
- Add development dependencies and configurations
- Add Sass module
- Remove blurry and non-authoritative osi logos. - Add official osi logos - available at https://opensource.org/node/442. - Create logo directory for logos. - Rename and move osi Ghana map to newly created brand directory. - Delete home directory. - Add favicon to main images directory.
- Add organisation details (name, URL, categories, etc.) with information for SEO and Web app manifest (icon, site title, background and theme colour and organisation name mainly). - Remove duplicate PostCSS plugin reference.
- Add basic layout index.js page with page fragments as footer.js, header.js and navigation.js. - Add components directory (contains page layout and fragments) under /src. - Update index.js under pages to make use of page layout and fragments.
- Apply https://www.gitignore.io rules (JetBrains+all and JetBrains+all Patch) to .gitignore. - Remove duplicate .DS_Store rule. - Refactor joinus.js as join.js. - Update navigation.js with menu items.
- Add logo.js under components. - Update navigation.js with logo reference. - Update all remaining pages (about.js, events.js, join.js and projects.js) to make use of general layout.
- Format entire project running Prettier.
- Update project name, description and author. - Add osc-ghana as additional keyword. - Point repository and bugs URL to correct repository.
- Remove .tailwind.config.js.swp (irrelevant swap file). .tailwind.config.js updates: - Add tw- prefix to alienate potential utilities naming conflicts. - Enforce regular screen breakpoints (640px, 768px, 1024px and 1280px).
- Add Gatsby plugin "gatsby-plugin-react-svg". - Configure "gatsby-plugin-react-svg".
- Import logo with Webpack; drop use of GraphQL. - Format 404.js running Prettier.
- Complete regular navigation menu for medium and large screens. - Complete alternate navigation menu for smaller screens.
- Minor import stylesheet improvement.
- Add "stylelint" and "stylelint-config-standard" as development dependencies. - Add "stylelint-scss" as dependency. - Add "sass" and "stylelint" scripts. - Add .stylelintrc.json for stylelint rules.
- Add _button.scss, _footer.scss and _navigation.scss partials under assets/scss/components. - Link _button.scss, _footer.scss and _navigation.scss partials to assets/scss/components/_index.scss. - Add assets/scss/index.scss as main index.
nyedidikeke
requested review from
dagasonhackason,
iamsirmike,
oscghanaadmin and
jaeyholic
January 26, 2020 19:25
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly make the navigation bar responsive.
- Enable regular navigation menu for smaller devices. - Fine tune regular navigation menu for smaller devices. - Remove alternate menu for smaller devices. - Update stylesheets with corresponding modifications (remove _button.scss partial, etc.)
- Add "main" parameter to Layout component. - Update header.js with "children" parameter to <header>. - Update all pages making use of "main" Layout component parameter.
- Add _header.scss partial. - Refactor _index.scss partial. - Add hero section to index.js as "header" parameter. - Update stylesheets.
- Minor layout adjustment.
- Refactor index.scss. - Create _general.scss. - Update _index.scss partial. - Create _button.scss partial. - Update _header.scss partial and stylesheets. - Update index.js (add call to action area with "Join Community" and "View Projects" buttons).
- Update index.js, _button.scss partial and stylesheets.
nyedidikeke
requested review from
oscghanaadmin
and removed request for
dagasonhackason,
jaeyholic and
iamsirmike
February 1, 2020 21:06
Completed a week ago. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.