fix components config #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SampsonCrowley
force-pushed
the
master-components-config
branch
6 times, most recently
from
e508a22
to
4c84a1c
Compare
marcandre
approved these changes
May 3, 2019
SampsonCrowley
force-pushed
the
master-components-config
branch
from
4c84a1c
to
a4fd11a
Compare
|
@marcandre made a few tweaks based on your feedback, but left most of the possibly redundant testing in. I'm of the opinion that it's better to "over-test" than to under do it. These scenarios were just the best way i could think of to triple check that I was testing exactly what I was expecting. I am more than willing to modify as needed though |
SampsonCrowley
force-pushed
the
master-components-config
branch
from
a4fd11a
to
f72d266
Compare
SampsonCrowley
force-pushed
the
master-components-config
branch
from
f72d266
to
a1e8efc
Compare
|
Excellent work 🙇 |
|
BTW, the convention in Ruby is to use only implicit conversion ( |
|
Excellent point. Thanks for all the feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes config to actually allow setting components tags as mentioned in README.md
fixes config error portion of issue #95