-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run once utility to automate creation of "member_details" where it doesn't already exist #1634
base: master
Are you sure you want to change the base?
Conversation
c654760
to
ea36bb5
Compare
@garethedwards-tass - in general I'm ok with adding the member_details, but as for the utility is there a reason to use custom built json functions, rather than the builtin: |
For these changes in particular the goal was to reduce additional changes to the json files |
I don't feel it's necessary to have this utility as part of the commit. As you said, it's a "run once" utility and we should expect newly added functions to include |
@KamasamaK I've removed the utilities |
@KamasamaK I've updated the return types |
No description provided.