Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run once utility to automate creation of "member_details" where it doesn't already exist #1634

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

garethedwards-tass
Copy link

No description provided.

@pfreitag
Copy link
Member

@garethedwards-tass - in general I'm ok with adding the member_details, but as for the utility is there a reason to use custom built json functions, rather than the builtin: isJSON, serializeJSON and deserializeJSON?

@garethedwards-tass
Copy link
Author

For these changes in particular the goal was to reduce additional changes to the json files

@KamasamaK
Copy link
Contributor

KamasamaK commented Mar 15, 2024

  1. base_param_index should be a number, not a string.
  2. It looks like returns is set to any for all of them, which should not be the case.

I don't feel it's necessary to have this utility as part of the commit. As you said, it's a "run once" utility and we should expect newly added functions to include member_details. I would recommend just including the JSON file changes in the commit and update the returns values. They will usually be the same as the returns value of the function itself, and in the rare cases it's not you can manually correct that before committing.

@ghedwards
Copy link

@KamasamaK I've removed the utilities

@ghedwards
Copy link

@KamasamaK I've updated the return types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants