Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incompatible -L flag in tree lib -L 1 on Windows #1296

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

zerosnacks
Copy link
Member

@zerosnacks zerosnacks commented Sep 16, 2024

Closes: #1149

The output isn't fully accurate now but good enough to get the point across

Copy link

Deploying foundry-book with  Cloudflare Pages  Cloudflare Pages

Latest commit: 08c66d4
Status: ✅  Deploy successful!
Preview URL: https://7865fb3d.foundry-book.pages.dev
Branch Preview URL: https://zerosnacks-fix-tree-command.foundry-book.pages.dev

View logs

@onbjerg onbjerg merged commit 2f2547e into master Sep 16, 2024
3 checks passed
@onbjerg onbjerg deleted the zerosnacks/fix-tree-command branch September 16, 2024 15:18
@DaniPopes
Copy link
Member

the output directory is autogenerated as you can see from the github diff... @zerosnacks

@zerosnacks
Copy link
Member Author

Triggered a re-run of the output directory to revert this change here: #1302

I don't see a good way to resolve #1149 considering the tree command doesn't have compatible flags on the different platforms and we don't make a claim of the commands being runnable on Windows

Going to mark the original ticket as not planned

@DaniPopes
Copy link
Member

Yeah that's fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Foundry book contains invalid command for witnessing lib structure after dependency installation
3 participants