feat(cast): add --timeout option
#9044
Conversation
PanGan21
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
PanGan21
changed the title
--timeout option
| /// The timeout will be used to override the default timeout for RPC. | ||
| /// Default value is 45s | ||
| #[arg(long, env = "ETH_RPC_TIMEOUT")] | ||
| pub timeout: Option<u64>, |
There was a problem hiding this comment.
I think we should add this to Config and RpcOpts, so that it's always available in get_provider across the codebase
There was a problem hiding this comment.
I tried this as first option in previous commit and it was conflicting with --timeout for other commands.
There was a problem hiding this comment.
So it would be possible but the flag should be named differently
There was a problem hiding this comment.
The other commands should also use the config's and RpcOpts timeout then
There was a problem hiding this comment.
They map thought to a different Config property. (example Config::transaction_timeout)
Here is an example of failing tests when timeout was in RpcOpts:
https://github.com/foundry-rs/foundry/actions/runs/11200334838/job/31133848891
Motivation
Context: #8959
Solution
The following pr adds
--timeoutoption to cast command overriding the default rpc timeout.