Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AnyDesk paths #165

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Add AnyDesk paths #165

merged 2 commits into from
Apr 8, 2024

Conversation

Poeloe
Copy link
Contributor

@Poeloe Poeloe commented Apr 4, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.49%. Comparing base (ec28bcd) to head (c4d26e7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #165   +/-   ##
=======================================
  Coverage   41.49%   41.49%           
=======================================
  Files          26       26           
  Lines        3314     3314           
=======================================
  Hits         1375     1375           
  Misses       1939     1939           
Flag Coverage Δ
unittests 41.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

acquire/acquire.py Outdated Show resolved Hide resolved
@Poeloe Poeloe force-pushed the feature/add-anydesk-paths branch from 700e23e to c4d26e7 Compare April 4, 2024 09:43
Comment on lines 1222 to +1223
("glob", "AppData/Roaming/AnyDesk/*.trace", from_user_home),
("glob", "AppData/Roaming/AnyDesk/*/*.trace", from_user_home),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
("glob", "AppData/Roaming/AnyDesk/*.trace", from_user_home),
("glob", "AppData/Roaming/AnyDesk/*/*.trace", from_user_home),
("glob", "AppData/Roaming/AnyDesk/**/*.trace", from_user_home),

Would this work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would work, but I don't know if it will negatively impact the runtime, since it will then traverse all of the paths

("dir", "sysvol/ProgramData/AnyDesk"),
("glob", "AppData/Roaming/AnyDesk/*.trace", from_user_home),
("glob", "AppData/Roaming/AnyDesk/*/*.trace", from_user_home),
# anydesk - Mac + Linux
("glob", ".anydesk*/*.trace", from_user_home),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking - is it actually .anydesk* or should it be .anydesk/*?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be like it is ;)

https://support.anydesk.com/knowledge/trace-files#trace-file-locations --> For the Custom Client, it could be located in ~/.anydesk_ad_<prefix>/anydesk_ad_<prefix>.trace or for the Standard Client just ~/.anydesk/anydesk.trace

@Poeloe Poeloe requested a review from Schamper April 5, 2024 14:55
@narimantos narimantos linked an issue Apr 8, 2024 that may be closed by this pull request
@Poeloe Poeloe merged commit 042a4a3 into main Apr 8, 2024
16 checks passed
@Poeloe Poeloe deleted the feature/add-anydesk-paths branch April 8, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collect additional Anydesk paths
4 participants