Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent error messages involving output-file #191

Merged
merged 6 commits into from
Sep 9, 2024

Conversation

twiggler
Copy link
Contributor

@twiggler twiggler commented Sep 4, 2024

Note: There are failing CI checks unrelated to this pr. After CI is fixed, this PR can be re-reviewed.

Make error messages concerning output-file consistent with the name of the flag.

extra:

  • git ignore acquire artifacts when running the package from the root.
  • fully git ignore the .tox directory

closes #169

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.60%. Comparing base (16f8afa) to head (e48041d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #191   +/-   ##
=======================================
  Coverage   44.60%   44.60%           
=======================================
  Files          26       26           
  Lines        3394     3394           
=======================================
  Hits         1514     1514           
  Misses       1880     1880           
Flag Coverage Δ
unittests 44.60% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.gitignore Outdated
Comment on lines 14 to 18

# Ignore artefacts created by an acquire run in the package directory
*.tar
*.log
*.report.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are only artifacts generate from where you run acquire. These do not need to be ignored as they are not build artifacts.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will move these to my local exclude file.

@Miauwkeru
Copy link
Contributor

Could you adjust the title of the PR to be a bit more informative of what it changes? And so it adheres to https://docs.dissect.tools/en/latest/contributing/style-guide.html

@twiggler twiggler changed the title Fix/inconsistent flag Fix inconsistent error messages involving output-file Sep 4, 2024
@twiggler twiggler merged commit de0ab7e into main Sep 9, 2024
16 of 18 checks passed
@twiggler twiggler deleted the fix/inconsistent-flag branch September 9, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent flag name in error message
3 participants