-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Acquire device list #198
Acquire device list #198
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #198 +/- ##
==========================================
+ Coverage 47.07% 47.09% +0.01%
==========================================
Files 26 26
Lines 3405 3421 +16
==========================================
+ Hits 1603 1611 +8
- Misses 1802 1810 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
f864602
to
b630248
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might it be a good idea to use the _windows_get_devices()
and co functions in dissect.target's local loader (loader.py
)? https://github.com/fox-it/dissect.target/blob/main/dissect/target/loaders/local.py#L337C1-L337C28
ce8c95c
to
79fc0e3
Compare
79fc0e3
to
f31afce
Compare
f31afce
to
1bdc2e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(DIS-897)