Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return the exit code instead of exiting in main #211

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Conversation

Schamper
Copy link
Member

@Schamper Schamper commented Jan 21, 2025

Noticed this while browsing this file looking for a way to do something.

@Schamper Schamper requested a review from Poeloe January 21, 2025 09:11
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 47.37%. Comparing base (1b3e67c) to head (6930f1b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
acquire/tools/decrypter.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #211   +/-   ##
=======================================
  Coverage   47.37%   47.37%           
=======================================
  Files          26       26           
  Lines        3466     3466           
=======================================
  Hits         1642     1642           
  Misses       1824     1824           
Flag Coverage Δ
unittests 47.37% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Schamper Schamper merged commit 7858007 into main Jan 21, 2025
16 of 20 checks passed
@Schamper Schamper deleted the fix-exit-code branch January 21, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants