-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add overloads for dumps and write for BC (v4) #54
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## refactor-v4 #54 +/- ##
===============================================
+ Coverage 90.49% 90.97% +0.47%
===============================================
Files 19 19
Lines 1694 2050 +356
===============================================
+ Hits 1533 1865 +332
- Misses 161 185 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
3f84516
to
ee0786c
Compare
fe7fda7
to
ebd9652
Compare
This adds overloads for the
.dumps()
and.write()
methods on types for backwards compatibility with the old API.For example, this enables the following syntax:
Similarly with the
.write()
function.It's open for discussion whether we should merge this in, or just face the changed API. I was mostly curious if it was possible at all.