Add the default() method back in (v4)
#55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schamper
force-pushed
the
v4-union-editing
branch
from
c96f259
to
5b38ad8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## refactor-v4 #55 +/- ##
===============================================
+ Coverage 90.93% 91.00% +0.07%
===============================================
Files 19 19
Lines 2040 2056 +16
===============================================
+ Hits 1855 1871 +16
Misses 185 185
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Schamper
changed the title
default() method back indefault() method back in (v4)
Schamper
force-pushed
the
v4-add-back-default
branch
from
ee2f197
to
3f55410
Compare
Schamper
added a commit
that referenced
this pull request
Jan 9, 2024
Schamper
added a commit
that referenced
this pull request
Feb 19, 2024
Schamper
added a commit
that referenced
this pull request
Mar 22, 2024
Schamper
added a commit
that referenced
this pull request
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missing in v4 still, resulting in some wrong default values. This PR adds it back in. Merges into #35.