Add XFS metadata: blocks per file and block size #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33 +/- ##
==========================================
+ Coverage 64.25% 64.50% +0.25%
==========================================
Files 4 4
Lines 414 417 +3
==========================================
+ Hits 266 269 +3
Misses 148 148
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Schamper
requested changes
Oct 7, 2024
dissect/xfs/xfs.py
Outdated
| @@ -294,6 +294,10 @@ def _has_large_extent_counts(self) -> bool: | |||
| def size(self) -> int: | |||
| return self.inode.di_size | |||
|
|
|||
| @property | |||
| def number_of_blocks(self) -> int: | |||
There was a problem hiding this comment.
Suggested change
| def number_of_blocks(self) -> int: | |
| def nblocks(self) -> int: |
tests/test_xfs.py
Outdated
| @@ -22,9 +23,11 @@ def test_xfs(xfs_bin): | |||
| assert list(root.listdir().keys()) == [".", "..", "test_file", "test_dir", "test_link"] | |||
|
|
|||
| test_file = xfs.get("test_file") | |||
| assert test_file.number_of_blocks == 1 | |||
There was a problem hiding this comment.
Suggested change
| assert test_file.number_of_blocks == 1 | |
| assert test_file.nblocks == 1 |
tests/test_xfs.py
Outdated
| assert test_file.open().read() == b"test content\n" | ||
|
|
||
| test_link = xfs.get("test_link") | ||
| assert test_link.number_of_blocks == 0 |
There was a problem hiding this comment.
Suggested change
| assert test_link.number_of_blocks == 0 | |
| assert test_link.nblocks == 0 |
tests/test_xfs.py
Outdated
| @@ -34,18 +37,22 @@ def test_xfs_sparse(xfs_sparse_bin): | |||
|
|
|||
| sparse_start = xfs.get("sparse_start") | |||
| assert sparse_start.size == 0x258000 | |||
| assert sparse_start.number_of_blocks == 200 | |||
There was a problem hiding this comment.
Suggested change
| assert sparse_start.number_of_blocks == 200 | |
| assert sparse_start.nblocks == 200 |
tests/test_xfs.py
Outdated
| assert sparse_start.dataruns() == [(None, 400), (1392, 200)] | ||
|
|
||
| sparse_hole = xfs.get("sparse_hole") | ||
| assert sparse_hole.size == 0x258000 | ||
| assert sparse_hole.number_of_blocks == 400 |
There was a problem hiding this comment.
Suggested change
| assert sparse_hole.number_of_blocks == 400 | |
| assert sparse_hole.nblocks == 400 |
tests/test_xfs.py
Outdated
| assert sparse_hole.dataruns() == [(1792, 200), (None, 200), (2192, 200)] | ||
|
|
||
| sparse_end = xfs.get("sparse_end") | ||
| assert sparse_end.size == 0x190000 | ||
| assert sparse_end.number_of_blocks == 200 |
There was a problem hiding this comment.
Suggested change
| assert sparse_end.number_of_blocks == 200 | |
| assert sparse_end.nblocks == 200 |
tests/test_xfs.py
Outdated
| assert sparse_end.dataruns() == [(2392, 200), (None, 200)] | ||
|
|
||
| sparse_all = xfs.get("sparse_all") | ||
| assert sparse_all.size == 0x500000 | ||
| assert sparse_all.number_of_blocks == 0 |
There was a problem hiding this comment.
Suggested change
| assert sparse_all.number_of_blocks == 0 | |
| assert sparse_all.nblocks == 0 |
Schamper
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose blocks per file and the block size of the file system
Companion PR to fox-it/dissect.target#874
Closes #32