Make ipnetwork and ipaddress hashable

[Miauwkeru]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.92%. Comparing base (4e1a285) to head (4a21763).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
+ Coverage   83.89%   83.92%   +0.03%     
==========================================
  Files          34       34              
  Lines        3458     3466       +8     
==========================================
+ Hits         2901     2909       +8     
  Misses        557      557              

Flag	Coverage Δ
unittests	83.92% <100.00%> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yunzheng]

can you change to new style typing

[Miauwkeru]

can you change to new style typing

it will break the python3.8 compatibility if I change it to new style typing, which is why i haven't done so.

[yunzheng]

can you change to new style typing

it will break the python3.8 compatibility if I change it to new style typing, which is why i haven't done so.

should work fine due to from __future__ import annotations

[Miauwkeru]

can you change to new style typing

it will break the python3.8 compatibility if I change it to new style typing, which is why i haven't done so.

should work fine due to from __future__ import annotations

Ah, I see I checked it wrong. I tried x = str | int that doesn't work, but x: str | int = None does work. So its during assigning that it went wrong. My bad, changed the definitions.

[yunzheng]

some small suggestions and then it should be good to go!

already resolved