Drop Python 3.7 support #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3.7 is EOL since 27 June 2023. Minimal supported Python version for flow.record is now 3.8.
Codecov Report
@@ Coverage Diff @@
## main #88 +/- ##
=======================================
Coverage 79.22% 79.22%
=======================================
Files 32 32
Lines 2932 2932
=======================================
Hits 2323 2323
Misses 609 609
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Looks like |
The new dissect-workflow-template now also tests windows, so we can remove it.
Yes, 3.12 is expected to fail for now on this issue. Regarding the removal of the local windows tests, you can now also revert the change to tox.ini that was made when these tests were added. |
pyrco
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.7 is EOL since 27 June 2023.
Minimal supported Python version for flow.record is now 3.8.