perf(ts): simple monomorphic message parse

foxglove · Aug 15, 2024 · 3a86677 · 3a86677
1 parent 4fcdd33
commit 3a86677
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 2 deletions.
diff --git a/typescript/core/src/McapStreamReader.ts b/typescript/core/src/McapStreamReader.ts
@@ -2,7 +2,7 @@ import { crc32 } from "@foxglove/crc";
 
 import Reader from "./Reader";
 import { MCAP_MAGIC } from "./constants";
-import { parseMagic, parseRecord } from "./parse";
+import { monoParseMessage, parseMagic, parseRecord } from "./parse";
 import { Channel, DecompressHandlers, McapMagic, TypedMcapRecord, TypedMcapRecords } from "./types";
 
 type McapReaderOptions = {
@@ -233,7 +233,15 @@ export default class McapStreamReader {
           const view = new DataView(buffer.buffer, buffer.byteOffset, buffer.byteLength);
           const chunkReader = new Reader(view);
           let chunkRecord;
-          while ((chunkRecord = parseRecord(chunkReader, this.#validateCrcs))) {
+          while (true) {
+            if (chunkRecord = monoParseMessage(chunkReader)) {
+              yield chunkRecord;
+              continue;
+            }
+            chunkRecord = parseRecord(chunkReader, this.#validateCrcs)
+            if (!chunkRecord) {
+              break;
+            }
             switch (chunkRecord.type) {
               case "Unknown":
                 break;

diff --git a/typescript/core/src/parse.ts b/typescript/core/src/parse.ts
@@ -417,3 +417,28 @@ function parseDataEnd(reader: Reader, recordLength: number): TypedMcapRecord {
     dataSectionCrc,
   };
 }
+
+
+export function monoParseMessage(reader: Reader): TypedMcapRecord | undefined | null {
+  const RECORD_HEADER_SIZE = 1 /*opcode*/ + 8; /*record content length*/
+  if (reader.bytesRemaining() < RECORD_HEADER_SIZE) {
+    return undefined;
+  }
+  const start = reader.offset;
+  const opcode = reader.uint8();
+  const recordLength = reader.uint64();
+
+  if (opcode !== Opcode.MESSAGE) {
+    reader.offset = start; // Rewind to the start of the record
+    return null;
+  }
+
+  const recordLengthNum = Number(recordLength);
+
+  if (reader.bytesRemaining() < recordLengthNum) {
+    reader.offset = start; // Rewind to the start of the record
+    return undefined;
+  }
+
+  return parseMessage(reader, recordLengthNum);
+}