validate: check both message encoding and schema encoding #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snosenzo
approved these changes
Jun 24, 2024
| @@ -139,7 +139,7 @@ async function validate( | |||
| throw new Error(`Missing schema ${record.schemaId} for channel ${record.id}`); | |||
| } | |||
| let messageDeserializer: (data: ArrayBufferView) => unknown; | |||
| if (record.messageEncoding === "ros1") { | |||
| if (record.messageEncoding === "ros1" && schema.encoding === "ros1msg") { | |||
There was a problem hiding this comment.
nitty nit: feels a bit more natural to me to check schema first, then the message encoding, going from less specific to more specific.
There was a problem hiding this comment.
Screen.Recording.2024-06-24.at.12.27.47.PM.mov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validate example was incorrect for ros2msg/cdr channels, and it was also only checking the message encoding and not the schema encoding.