-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(ts): reuse Reader whilst parsing records #1212
Merged
Merged
Commits on Aug 12, 2024
-
perf(ts): reuse Reader whilst parsing records
This is both a refactor and perf boost, with more room for improvement, key changes: - Removes StreamBuffer, hoisted into McapStreamReader - Reuses Reader and DataView class across parse calls, only resetting them when necessary (e.g: append in McapStreamData) - Splits `parseRecord` into small scoped parsing functions, this itself is perf neutral (slightly positive) but facilitates future monomorphic fast paths - Moves offsets tracking into Reader which is cleaner and faster
Configuration menu - View commit details
-
Copy full SHA for 364de14 - Browse repository at this point
Copy the full SHA 364de14View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3eccc0 - Browse repository at this point
Copy the full SHA e3eccc0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7897fc3 - Browse repository at this point
Copy the full SHA 7897fc3View commit details
Commits on Aug 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b2e5fe9 - Browse repository at this point
Copy the full SHA b2e5fe9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a8f09f - Browse repository at this point
Copy the full SHA 3a8f09fView commit details -
Configuration menu - View commit details
-
Copy full SHA for e471521 - Browse repository at this point
Copy the full SHA e471521View commit details -
Configuration menu - View commit details
-
Copy full SHA for 68ca507 - Browse repository at this point
Copy the full SHA 68ca507View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4aadbc5 - Browse repository at this point
Copy the full SHA 4aadbc5View commit details
Commits on Aug 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6e54927 - Browse repository at this point
Copy the full SHA 6e54927View commit details
Commits on Aug 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4689528 - Browse repository at this point
Copy the full SHA 4689528View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.