Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(ts): reuse Reader whilst parsing records #1212

Merged
merged 10 commits into from
Aug 15, 2024

Commits on Aug 12, 2024

  1. perf(ts): reuse Reader whilst parsing records

    This is both a refactor and perf boost, with more room for improvement, key changes:
    - Removes StreamBuffer, hoisted into McapStreamReader
    - Reuses Reader and DataView class across parse calls, only resetting them when necessary (e.g: append in McapStreamData)
    - Splits `parseRecord` into small scoped parsing functions, this itself is perf neutral (slightly positive) but facilitates future monomorphic fast paths
    - Moves offsets tracking into Reader which is cleaner and faster
    AaronO committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    364de14 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e3eccc0 View commit details
    Browse the repository at this point in the history
  3. lint

    AaronO committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    7897fc3 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. cleanup: #buffer.consume()

    AaronO committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    b2e5fe9 View commit details
    Browse the repository at this point in the history
  2. simpler Reader.string()

    AaronO committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    3a8f09f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e471521 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    68ca507 View commit details
    Browse the repository at this point in the history
  5. parse fix attachment crc

    AaronO committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    4aadbc5 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. comments and nits

    AaronO committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    6e54927 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. add bool arg notes

    AaronO committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    4689528 View commit details
    Browse the repository at this point in the history