Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ef_alternator_data.js #220

Merged
merged 3 commits into from
Feb 26, 2025
Merged

Update ef_alternator_data.js #220

merged 3 commits into from
Feb 26, 2025

Conversation

radeonorama
Copy link
Contributor

Updated current425 to correct value type of "Current Watts". Changed the max to 900 as can sometimes get a bit of overspill on the watts when in certain charge modes

Updated current425 to correct value type of "Current Watts". 
Changed the max to 900 as can sometimes get a bit of overspill on the watts when in certain charge modes
@foxthefox
Copy link
Owner

Thank you for your contribution.
I have a question to the PR.
If current425 is some kind of load/power (and not a current) then we should also rename it accordingly.
but how is this different to "actPower" ? do actPower and current425 change in the same way?

@radeonorama
Copy link
Contributor Author

radeonorama commented Feb 26, 2025

actPower is the input watts to the alternator charger. current is the watts output from the alternator charger into the powerstation (in my case a delta pro)

looking at it in more detail it's quite interesting, the actPower appears to be the watts it's pulling from the alternator however, due to the voltage being higher or lower, it regulates the 800 outputted to the battery by presumably adjusting the volts.

EDIT: just switched to reverse charge mode to see how that reacts.

actPower is Alternator side and hidden within the EF official app.
current is powerstation side and the watt reading that is displayed within the EF official app.

It's essentially working just the same as a DC to DC charger where it regulates the required output voltage which ultimately ends up in the variants in wattage.

@foxthefox
Copy link
Owner

if I understand it right, the actPower should be renamed to alternatorPower
and the current425 should be named stationPower?
Or do you have better suggestion?

@radeonorama
Copy link
Contributor Author

hmm, it's a bit more complex on the alternator side. Technically when in reverse mode, you're back feeding the starter battery rather than to the alternator as the whole point is to charge the starter battery.

That said, it is all about alternator and powerstation so i guess is the most logical without it getting too over complicated.

Do you want me to change the code and do another pull request?

I'm really keen to see the control side of things implemented too. Is there anything I can do to help that along?

Copy link
Contributor Author

@radeonorama radeonorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjusted for Alternator Power and Station Power

Missed a few elements in the amendment. Needed to be switched to a sensor and the max value bumped t0 900
Copy link
Contributor Author

@radeonorama radeonorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed increasing the max to 900 and changing out to be a sensor

@foxthefox
Copy link
Owner

foxthefox commented Feb 26, 2025

I will do the renaming afterwards.

Edit.
My next task is the command portion. You can help and do some checks.

@foxthefox foxthefox merged commit 17baf31 into foxthefox:main Feb 26, 2025
11 checks passed
@radeonorama
Copy link
Contributor Author

Great! I'm all for it. Let me know what I need to do as and when and I'll be on hand straight away! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants