Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce non-duplication constraints on task groups #1865

Merged

Conversation

ychiucco
Copy link
Collaborator

@ychiucco ychiucco commented Oct 8, 2024

closes #1859

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md
  • I added logging to new code - if appropriate.
  • I merged main into the current branch.

@ychiucco ychiucco linked an issue Oct 8, 2024 that may be closed by this pull request
8 tasks
Copy link

github-actions bot commented Oct 8, 2024

Benchmark comparison

GET /api/alive/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 0.9 1.0 0.90 0.0 0.0
power 0.8 0.8 1.00 0.0 0.0
dataset 0.8 0.8 1.00 0.0 0.0
project 0.8 0.8 1.00 0.0 0.0
job 0.8 0.8 1.00 0.0 0.0

GET /api/v2/dataset/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 12.2 10.4 1.17 0.6 0.6
power 409.2 406.0 1.01 389.0 389.0
dataset 153.9 157.2 0.98 145.6 145.6
project 48.8 50.0 0.98 50.9 50.9
job 28.1 28.6 0.98 35.3 35.3

GET /api/v2/job/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.9 7.1 0.97 2.2 2.2
power 141.3 142.6 0.99 652.4 652.4
dataset 141.0 142.7 0.99 905.6 905.6
project 49.8 49.8 1.00 283.9 283.9
job 39.1 39.2 1.00 225.0 225.0

GET /api/v2/project/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 8.1 8.1 1.00 0.1 0.1
power 7.9 8.1 0.98 0.1 0.1
dataset 7.7 8.1 0.95 0.1 0.1
project 9.8 10.0 0.98 2.3 2.3
job 8.0 8.0 1.00 0.1 0.1

GET /api/v2/task/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.9 6.7 1.03 0.8 0.8
power 6.6 7.3 0.90 0.8 0.8
dataset 6.6 7.2 0.92 0.8 0.8
project 6.4 6.5 0.98 0.8 0.8
job 6.4 6.4 1.00 0.8 0.8

GET /api/v2/workflow/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 12.4 12.4 1.00 0.8 0.8
power 26.2 26.9 0.97 29.6 29.6
dataset 21.2 20.7 1.02 17.0 17.0
project 23.4 27.5 0.85 21.4 21.4
job 11.2 12.2 0.92 0.8 0.8

POST /api/v2/project/3/dataset/412/images/query/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 150.9 156.6 0.96 275.1 275.1

GET /auth/current-user/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 5.3 5.3 1.00 0.2 0.2
power 5.2 5.2 1.00 0.2 0.2
dataset 5.2 5.2 1.00 0.2 0.2
project 5.2 5.0 1.04 0.2 0.2
job 5.1 5.0 1.02 0.1 0.1

POST /auth/token/login/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 263.7 264.6 1.00 0.2 0.2

Copy link

github-actions bot commented Oct 8, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_server/app/routes/api/v2
  _aux_functions_tasks.py
  task.py
  task_group.py
  fractal_server/app/runner/executors/slurm/sudo
  executor.py
Project Total  

This report was generated by python-coverage-comment-action

@ychiucco ychiucco merged commit 015ae2c into main Oct 9, 2024
@ychiucco ychiucco deleted the 1859-enforce-non-duplication-constraints-on-task-groups branch October 9, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enforce non-duplication constraints on task groups
2 participants