Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflow-apply error handling #665

Merged
merged 6 commits into from
May 4, 2023
Merged

workflow-apply error handling #665

merged 6 commits into from
May 4, 2023

Conversation

ychiucco
Copy link
Collaborator

@ychiucco ychiucco commented May 4, 2023 •
edited by tcompa
Loading

closes 591
closes #616

@ychiucco ychiucco linked an issue May 4, 2023 that may be closed by this pull request
Catch error in workflow-apply endpoint #591
Closed
@github-actions
Copy link

github-actions bot commented May 4, 2023 •
edited
Loading

Coverage report

The coverage rate went from 87.31% to 87.38% ⬆️
The branch rate is 76%.

100% of new lines are covered.

Diff Coverage details (click to unfold)

fractal_server/app/api/v1/project.py

100% of new lines are covered (69.25% of the complete file).

tcompa
tcompa reviewed May 4, 2023
View reviewed changes
tests/test_project_api.py Outdated Show resolved Hide resolved
@tcompa tcompa removed a link to an issue May 4, 2023
Catch error in workflow-apply endpoint #591
Closed
@tcompa
Copy link
Collaborator

tcompa commented May 4, 2023

Note: the local (sqlite-based) CI still fails, as due to #661.

@tcompa tcompa merged commit c73ec18 into main May 4, 2023
@tcompa tcompa deleted the 591-catch-error-in-workflow-apply-endpoint branch May 4, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcompa tcompa tcompa left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle the case where workflow-apply fails because datasets have zero resources
2 participants
@ychiucco @tcompa