Fix task collection with sqlite #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)fractal_server/app/api/v1/task.py
fractal_server/init.py
|
|
For the record: With #664, we tried to be very general and support background tasks with some flexibility (that is, they could use either sync or async db session). For some unclear reason, we were relying on async sessions for task-collection and on sync session for workflow execution. With this PR we simplify things a bit, and we switch to always using sync DB sessions in background tasks, which has never lead to errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #661 (again)