Merge pull request #269 from framesjs/feat/relative-image-urls

feat: relative url support for images
framesjs · Apr 2, 2024 · 7c6e54f · 7c6e54f
2 parents 9965461 + f7b00b0
commit 7c6e54f
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/.changeset/light-fireants-rest.md b/.changeset/light-fireants-rest.md
@@ -0,0 +1,5 @@
+---
+"frames.js": patch
+---
+
+feat: relative url support for images
diff --git a/packages/frames.js/src/middleware/openframes.test.ts b/packages/frames.js/src/middleware/openframes.test.ts
@@ -116,6 +116,8 @@ describe("openframes middleware", () => {
         method: "POST",
         body: JSON.stringify(signedPayload),
       }),
+      url: new URL("https://example.com").toString(),
+      basePath: "/",
     } as any;
 
     const mw1 = openframes({

diff --git a/packages/frames.js/src/middleware/renderResponse.ts b/packages/frames.js/src/middleware/renderResponse.ts
@@ -109,7 +109,11 @@ export function renderResponse(): FramesMiddleware<any, {}> {
         // and disabling it, has no effect on final bundle size of app
         image:
           typeof result.image === "string"
-            ? result.image
+            ? generateTargetURL({
+                target: result.image,
+                currentURL: context.url,
+                basePath: context.basePath,
+              })
             : await renderImage(result.image, result.imageOptions).catch(
                 (e) => {
                   console.error(e);