fix: only allow http(s) urls in link buttons #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
packages/render/src/use-frame.tsx
Outdated
Comment on lines
381
to
387
| const locationUrl = new URL(frameButton.target); | ||
|
|
||
| // Reject non-http(s) URLs | ||
| if ( | ||
| locationUrl.protocol !== "http:" && | ||
| locationUrl.protocol !== "https:" | ||
| ) { |
There was a problem hiding this comment.
Could we extract this to some sort of isLinkTargetValid() or something like that?
michalkvasnicak
approved these changes
Oct 15, 2024
stephancill
force-pushed
the
fix/link-xss-patch
branch
from
8c7a7da
to
ce3587e
Compare
stephancill
force-pushed
the
fix/link-xss-patch
branch
from
ce3587e
to
72171b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Merge Checklist