Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: handle transactions from composer actions in debugger #513

Merged
merged 5 commits into from
Oct 24, 2024
Merged

feat: handle transactions from composer actions in debugger #513

merged 5 commits into from
Oct 24, 2024

Conversation

stephancill
Copy link
Contributor

@stephancill stephancill commented Oct 22, 2024 •
edited
Loading

Change Summary

  • Example transaction miniapp
  • Support transactions in debugger (incl. error handling)
  • Refactor types

Merge Checklist

  • PR has a Changeset
  • PR includes documentation if necessary
  • PR updates the boilerplates if necessary

@vercel Vercel
Copy link

vercel bot commented Oct 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frames-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 11:06am
framesjs-debugger ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 11:06am
framesjs-examples ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 11:06am

@stephancill stephancill marked this pull request as ready for review October 24, 2024 07:41
michalkvasnicak
michalkvasnicak reviewed Oct 24, 2024
View reviewed changes
packages/render/src/types.ts
@@ -74,7 +78,7 @@ export type OnConnectWalletFunc = () => void;
export type SignFrameActionFunc<
TSignerStorageType = Record<string, unknown>,
TFrameActionBodyType extends FrameActionBodyPayload = FrameActionBodyPayload,
TFrameContextType extends FrameContext = FarcasterFrameContext,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably create a prettier config that doesn't remove those commas. Introduces unnecessary changes in diff.

michalkvasnicak
michalkvasnicak approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@michalkvasnicak michalkvasnicak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, great work! I would just introduce prettier config and keep the trailingComma: all so it doesn't change the types.

@stephancill stephancill merged commit ac0af6c into dev Oct 24, 2024
6 of 8 checks passed
@stephancill stephancill deleted the feat/miniapp-txs branch October 24, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalkvasnicak michalkvasnicak michalkvasnicak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephancill @michalkvasnicak